Review Request 128817: Rewrite completion page in CSV Importer

[Łukasz Wojniłowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128817/
-----------------------------------------------------------

Review request for KMymoney.


Repository: kmymoney


Description
-------

1) shortened updateDecimalSymbol and renamed it to
validateDecimalSymbol,
2) introduced detectDecimalSymbol for autodetecting decimal symbol,
3) simplified createStatement,
4) simplified and deduplicated slotImportClicked,
5) new decimal symbol option 'auto' for columns with various decimal
symbols,
6) decimal symbols gets checked every time completion page is opened and
date format as well.


Diffs
-----

  kmymoney/plugins/csvimport/completionwizardpage.ui 616e0c3 
  kmymoney/plugins/csvimport/csvdialog.h 59e6898 
  kmymoney/plugins/csvimport/csvdialog.cpp ed9e1d8 
  kmymoney/plugins/csvimport/csvwizard.h ecec5b0 
  kmymoney/plugins/csvimport/csvwizard.cpp b576dea 
  kmymoney/plugins/csvimport/investprocessing.h 902f9bb 
  kmymoney/plugins/csvimport/investprocessing.cpp f050441 

Diff: https://git.reviewboard.kde.org/r/128817/diff/


Testing
-------


Thanks,

Łukasz Wojniłowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160903/3e7b50da/attachment.html>