Review Request 129116: Fix 'Exported templates does not have any title and description'.

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129116/#review101134
-----------------------------------------------------------




kmymoney/kmymoney.cpp (line 2185)
<https://git.reviewboard.kde.org/r/129116/#comment67782>

    Does https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0 apply if you don't assign a parent object to the dialog? I am not sure hence I am asking.
    
    It might also be good to compare the return value with QDialog::Accepted which makes the code more readable.


- Thomas Baumgart


On Okt. 17, 2016, 9:07 vorm., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129116/
> -----------------------------------------------------------
> 
> (Updated Okt. 17, 2016, 9:07 vorm.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Bugs: 370224
>     http://bugs.kde.org/show_bug.cgi?id=370224
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Before exporting a dialog is now shown with which users can fill
> in title, short and long description.
> 
> BUG:370224
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneytemplate.h 888178bc73b83686e237c6f36761a2eb790c363b 
>   kmymoney/converter/mymoneytemplate.cpp f482779b2e0825e146181e7df9387e741e1437f1 
>   kmymoney/dialogs/CMakeLists.txt 0daa6f63de08a37a7e135ba9b649c35c44fdcbc9 
>   kmymoney/dialogs/ktemplateexportdlg.h PRE-CREATION 
>   kmymoney/dialogs/ktemplateexportdlg.cpp PRE-CREATION 
>   kmymoney/dialogs/ktemplateexportdlg.ui PRE-CREATION 
>   kmymoney/kmymoney.cpp a4251f031cee280983aa67c55447d3f97865dcbd 
> 
> Diff: https://git.reviewboard.kde.org/r/129116/diff/
> 
> 
> Testing
> -------
> 
> tested on 4.8 branch
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20161127/d0810809/attachment.html>