Review Request 129116: Fix 'Exported templates does not have any title and description'.

[Ralf Habacker]

> On Okt. 30, 2016, 1:57 nachm., Christian David wrote:
> > kmymoney/kmymoney.cpp, line 2185
> > <https://git.reviewboard.kde.org/r/129116/diff/2/?file=481815#file481815line2185>
> >
> >     What happens if the user selects the abort button?
> 
> Ralf Habacker wrote:
>     The template will not be exported.

The complete use case 'User wants to export template' is: 

1. show file save as dialog
2. if user cancels dialog, save is canceled
3. template info dialog pops up
4. if user cancels dialog, save is canceled 

There would be also the following variant:

1. show template info dialog
2. if user cancels dialog, save is canceled
3. show file save as dialog
4. if user cancels dialog, save is canceled 

Please let me know if this looks better, so I can update the patch.

Are there any more open issues which blocks pressing 'ship it' ?


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129116/#review100402
-----------------------------------------------------------


On Okt. 17, 2016, 9:07 vorm., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129116/
> -----------------------------------------------------------
> 
> (Updated Okt. 17, 2016, 9:07 vorm.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Bugs: 370224
>     http://bugs.kde.org/show_bug.cgi?id=370224
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Before exporting a dialog is now shown with which users can fill
> in title, short and long description.
> 
> BUG:370224
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneytemplate.h 888178bc73b83686e237c6f36761a2eb790c363b 
>   kmymoney/converter/mymoneytemplate.cpp f482779b2e0825e146181e7df9387e741e1437f1 
>   kmymoney/dialogs/CMakeLists.txt 0daa6f63de08a37a7e135ba9b649c35c44fdcbc9 
>   kmymoney/dialogs/ktemplateexportdlg.h PRE-CREATION 
>   kmymoney/dialogs/ktemplateexportdlg.cpp PRE-CREATION 
>   kmymoney/dialogs/ktemplateexportdlg.ui PRE-CREATION 
>   kmymoney/kmymoney.cpp a4251f031cee280983aa67c55447d3f97865dcbd 
> 
> Diff: https://git.reviewboard.kde.org/r/129116/diff/
> 
> 
> Testing
> -------
> 
> tested on 4.8 branch
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20161124/43014662/attachment.html>