Review Request 127920: Use KAccountSelectDlg to select brokerage account

[Łukasz Wojniłowicz]

> On May 15, 2016, 8:08 a.m., Thomas Baumgart wrote:
> > kmymoney/converter/mymoneystatementreader.cpp, line 383
> > <https://git.reviewboard.kde.org/r/127920/diff/2/?file=464778#file464778line383>
> >
> >     This seems to be superfluous since you clear the id of m_brokerageAccount with the assignment in the previous code line.

>I cannot test/comment on the other parts as I don't have importable investment accounts and don't use CSV importer.

Would you like test file and test case from me?


>This seems to be superfluous since you clear the id of m_brokerageAccount with the assignment in the previous code line.

You're right, for now it's superfluous, but in future I want to...

```m_brokerageAccount = MyMoneyAccount();```

...insert here...

```if (m_brokerageAccount.id().isEmpty())```

...something for taking account information from statement source that would look similar to this...


    if (!s.m_accountId.isEmpty()) {
      try {
        m_account = MyMoneyFile::instance()->account(s.m_accountId);
      } catch (const MyMoneyException &) {
        qDebug("Received reference '%s' to unknown account in statement", qPrintable(s.m_accountId));
      }
    }
    
...where `m_account` would be replaced by `m_brokerageAccount`


- Łukasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127920/#review95474
-----------------------------------------------------------


On May 14, 2016, 9:44 p.m., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127920/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 9:44 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 363082
>     http://bugs.kde.org/show_bug.cgi?id=363082
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> During import of investment statement user is asked through simple input
> window to select brokerage account into which he wants to import. This
> patch changes input window to account selector.
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneystatementreader.h 80da202 
>   kmymoney/converter/mymoneystatementreader.cpp 2df256d 
>   kmymoney/plugins/csvimport/investprocessing.cpp 9061623 
>   kmymoney/plugins/csvimport/redefinedlg.cpp 207051e 
> 
> Diff: https://git.reviewboard.kde.org/r/127920/diff/
> 
> 
> Testing
> -------
> 
> Imported my test csv file with investment statement.
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160515/9b7f2fb1/attachment.html>