Review Request 127920: Use KAccountSelectDlg to select brokerage account

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127920/#review95474
-----------------------------------------------------------



I cannot test/comment on the other parts as I don't have importable investment accounts and don't use CSV importer.


kmymoney/converter/mymoneystatementreader.cpp (line 383)
<https://git.reviewboard.kde.org/r/127920/#comment64724>

    This seems to be superfluous since you clear the id of m_brokerageAccount with the assignment in the previous code line.


- Thomas Baumgart


On Mai 14, 2016, 9:44 nachm., Łukasz Wojniłowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127920/
> -----------------------------------------------------------
> 
> (Updated Mai 14, 2016, 9:44 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 363082
>     http://bugs.kde.org/show_bug.cgi?id=363082
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> During import of investment statement user is asked through simple input
> window to select brokerage account into which he wants to import. This
> patch changes input window to account selector.
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneystatementreader.h 80da202 
>   kmymoney/converter/mymoneystatementreader.cpp 2df256d 
>   kmymoney/plugins/csvimport/investprocessing.cpp 9061623 
>   kmymoney/plugins/csvimport/redefinedlg.cpp 207051e 
> 
> Diff: https://git.reviewboard.kde.org/r/127920/diff/
> 
> 
> Testing
> -------
> 
> Imported my test csv file with investment statement.
> 
> 
> Thanks,
> 
> Łukasz Wojniłowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160515/33e53bcb/attachment.html>