Review Request 127556: Quit application if all windows were closed, refactor main()

Christian David christian-david at web.de
Thu May 5 18:24:59 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127556/
-----------------------------------------------------------

(Updated May 5, 2016, 6:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney and Cristian Oneț.


Changes
-------

Submitted with commit ecdbc1c5be7d3a2ced359b80b938b97b3aa86c69 by Christian Dávid to branch frameworks.


Repository: kmymoney


Description
-------

Allow QApplication to quit if all windows were closed. Otherwise
KMyMoney would never shut down.

Used this commit for minor changes which simplify the code.

Most important is the removal of ```app.setQuitOnLastWindowClosed(false);```. Is there a reason why it was added?


Diffs
-----

  kmymoney/kmymoney.cpp 0d0a317d753e9c48740180d13235163928687b2c 
  kmymoney/main.cpp cf77030aeb7de0f744bc2cf928514568d564e2e8 

Diff: https://git.reviewboard.kde.org/r/127556/diff/


Testing
-------

Started and closed the app.


Thanks,

Christian David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160505/15dfea0a/attachment-0001.html>


More information about the KMyMoney-devel mailing list