Help needed in approving kdiagram bug fix

[Thomas Baumgart]

Hi,

On Sunday 27 March 2016 02:22:01 4ernov wrote:

> Hello,
> 
> some time ago I assigned a review request concerning a bug in
> kdiagram: https://git.reviewboard.kde.org/r/127272/ It leads to crash
> in KMyMoney, "frameworks" branch, which happens on applying any
> changes to some existing report. The issue and fix are quite trivial,
> but nobody seemed to observe them, but since the request is published,
> I'm afraid, it wouldn't be good to commit this change without
> approving.
> 
> I just wanted to ask if someone here could help with this, as actually
> it may affect KMyMoney in its KF5 version.

I dropped a comment with the review. I had a direct contact into KDAB where 
this comes from. I will ask him to take a look at your review request as well 
to figure out what the reason for the addition of that check was.

-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
A crash turns an expensive computer into a simple stone!
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 225 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160327/bc95b375/attachment.sig>