Review Request 128061: Fix precision of split value

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128061/#review96153
-----------------------------------------------------------



>From the list -
https://bugs.kde.org/show_bug.cgi?id=345655

--- Comment #18 from allan <agander93 at gmail.com> ---
Referring back to comments #3, #4,  #5, and
https://bugs.kde.org/show_bug.cgi?id=303026, does that issue now need revisiting?

--- Comment #19 from Thomas Baumgart <tbaumgart at kde.org> ---
Allan, good point. The modification is almost identical, though it differs a
bit. The rounding problem caught in https://bugs.kde.org/show_bug.cgi?id=303026
could still happen. Can you please comment on reviewboard so that we can think
of how to deal with the situation? It would be nice if you can provide me with
a testcase (probably just different values) that fails.

- Allan Anderson


On May 30, 2016, 6:10 p.m., Thomas Baumgart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128061/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 6:10 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 345655
>     http://bugs.kde.org/show_bug.cgi?id=345655
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> The problem described in bug 345655 is caused by a fraction of the splits value that is larger than the fraction of the accounts currency. This leads to the effect, that values are displayed with correct value but the underlying value used for calculations is not equal to the amount displayed. This will end up in KMyMoney presenting the user strange messages like 'Unassigned value of 0.00' which do not make sense. The difference is in reality between 0 and 0.01, e.g. 0.008.
> 
> The attached patch resolves this problem by rounding the numbers to the correct fraction of the referrenced account.
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.h 0fd558b 
>   kmymoney/mymoney/mymoneyfile.cpp 568675c 
>   kmymoney/mymoney/mymoneyfiletest.h 657ed39 
>   kmymoney/mymoney/mymoneyfiletest.cpp 810b15f 
> 
> Diff: https://git.reviewboard.kde.org/r/128061/diff/
> 
> 
> Testing
> -------
> 
> Test case is part of the patch. It uses the values provided in the sample attached to the bug 345655 entry.
> 
> 
> Thanks,
> 
> Thomas Baumgart
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160602/443fb850/attachment.html>