<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128061/">https://git.reviewboard.kde.org/r/128061/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From the list -
https://bugs.kde.org/show_bug.cgi?id=345655</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">--- Comment #18 from allan <a href="mailto:agander93@gmail.com" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">agander93@gmail.com</a> ---
Referring back to comments #3, #4, #5, and
https://bugs.kde.org/show_bug.cgi?id=303026, does that issue now need revisiting?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">--- Comment #19 from Thomas Baumgart <a href="mailto:tbaumgart@kde.org" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">tbaumgart@kde.org</a> ---
Allan, good point. The modification is almost identical, though it differs a
bit. The rounding problem caught in https://bugs.kde.org/show_bug.cgi?id=303026
could still happen. Can you please comment on reviewboard so that we can think
of how to deal with the situation? It would be nice if you can provide me with
a testcase (probably just different values) that fails.</p></pre>
<br />
<p>- Allan Anderson</p>
<br />
<p>On May 30th, 2016, 6:10 p.m. UTC, Thomas Baumgart wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Thomas Baumgart.</div>
<p style="color: grey;"><i>Updated May 30, 2016, 6:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=345655">345655</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The problem described in bug 345655 is caused by a fraction of the splits value that is larger than the fraction of the accounts currency. This leads to the effect, that values are displayed with correct value but the underlying value used for calculations is not equal to the amount displayed. This will end up in KMyMoney presenting the user strange messages like 'Unassigned value of 0.00' which do not make sense. The difference is in reality between 0 and 0.01, e.g. 0.008.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The attached patch resolves this problem by rounding the numbers to the correct fraction of the referrenced account.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Test case is part of the patch. It uses the values provided in the sample attached to the bug 345655 entry.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(0fd558b)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(568675c)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.h <span style="color: grey">(657ed39)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.cpp <span style="color: grey">(810b15f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128061/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>