Review Request 128470: Let Qt decide about CSVWizard size
Łukasz Wojniłowicz
lukasz.wojnilowicz at gmail.com
Sat Jul 16 15:36:20 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128470/
-----------------------------------------------------------
Review request for KMymoney.
Repository: kmymoney
Description
-------
CSVWizard window size should be relative and not absolute, so the window
can adapt itself according to user settings and display device.
I guess this review contains also content of review #128469, but reviewboard doesn't accept diff otherwise.
What I changed here is:
1) changed KComboBox to QComboBox, because we don't use completion,
2) removed fixed policy out of every element,
3) removed redundant settings,
4) removed maximum/minimum size hints,
5) removed fixed size fonts,
6) removed code for resizing CSVWizard according to hardcoded values,
7) made every page resizable (i.e. steady expansion in all directions of available area),
8) made page layouts consistent,
9) enabled wordwrap for header of every page to avoid unsolicited window stretching.
Diffs
-----
kmymoney/plugins/csvimport/bankingwizardpage.ui 95e5276
kmymoney/plugins/csvimport/completionwizardpage.ui ce62f00
kmymoney/plugins/csvimport/csvdialog.h d226665
kmymoney/plugins/csvimport/csvdialog.cpp 4fff108
kmymoney/plugins/csvimport/csvwizard.h 0bf1e59
kmymoney/plugins/csvimport/csvwizard.cpp 39bf9f2
kmymoney/plugins/csvimport/csvwizard.ui 5c42f46
kmymoney/plugins/csvimport/introwizardpage.ui bc0f850
kmymoney/plugins/csvimport/investmentwizardpage.ui 46f6e29
kmymoney/plugins/csvimport/investprocessing.cpp e0d2b8f
kmymoney/plugins/csvimport/lines-datewizardpage.ui 5d21372
kmymoney/plugins/csvimport/redefinedlgdecl.ui 341e7bd
kmymoney/plugins/csvimport/separatorwizardpage.ui 2831133
kmymoney/plugins/csvimport/symboltabledlg.ui 60f9166
Diff: https://git.reviewboard.kde.org/r/128470/diff/
Testing
-------
Banking and investment statement CSV imports; window resizing; different dpi settings
Thanks,
Łukasz Wojniłowicz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160716/773d49bd/attachment.html>
More information about the KMyMoney-devel
mailing list