<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128470/">https://git.reviewboard.kde.org/r/128470/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CSVWizard window size should be relative and not absolute, so the window
can adapt itself according to user settings and display device.
I guess this review contains also content of review #128469, but reviewboard doesn't accept diff otherwise.
What I changed here is:
1) changed KComboBox to QComboBox, because we don't use completion,
2) removed fixed policy out of every element,
3) removed redundant settings,
4) removed maximum/minimum size hints,
5) removed fixed size fonts,
6) removed code for resizing CSVWizard according to hardcoded values,
7) made every page resizable (i.e. steady expansion in all directions of available area),
8) made page layouts consistent,
9) enabled wordwrap for header of every page to avoid unsolicited window stretching.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Banking and investment statement CSV imports; window resizing; different dpi settings</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/bankingwizardpage.ui <span style="color: grey">(95e5276)</span></li>
<li>kmymoney/plugins/csvimport/completionwizardpage.ui <span style="color: grey">(ce62f00)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(d226665)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(4fff108)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.h <span style="color: grey">(0bf1e59)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(39bf9f2)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.ui <span style="color: grey">(5c42f46)</span></li>
<li>kmymoney/plugins/csvimport/introwizardpage.ui <span style="color: grey">(bc0f850)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.ui <span style="color: grey">(46f6e29)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(e0d2b8f)</span></li>
<li>kmymoney/plugins/csvimport/lines-datewizardpage.ui <span style="color: grey">(5d21372)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlgdecl.ui <span style="color: grey">(341e7bd)</span></li>
<li>kmymoney/plugins/csvimport/separatorwizardpage.ui <span style="color: grey">(2831133)</span></li>
<li>kmymoney/plugins/csvimport/symboltabledlg.ui <span style="color: grey">(60f9166)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128470/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>