[Kmymoney-devel] Review Request 126536: kbanking: Fix build without qtquick1
Heiko Becker
heirecka at exherbo.org
Mon Jan 11 13:18:56 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126536/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 1:18 p.m.)
Status
------
This change has been marked as submitted.
Review request for KMymoney.
Changes
-------
Submitted with commit 3da33087af86e4b04a6f035819c2b8c8d583b003 by Heiko Becker to branch frameworks.
Repository: kmymoney
Description
-------
This accidentally worked when I still had qtquick1 installed. Without
it the build fails with "ui_chiptandialog.h:13:42: fatal error:
QtDeclarative/QDeclarativeView: No such file or directory".
The build system doesn't search for it and isn't really necessary
anymore so I removed the unused <class> part from chiptandialog.ui and
used the appropriate enum from QtQuickWidgets.
Diffs
-----
kmymoney/plugins/kbanking/widgets/chiptandialog.cpp c2d683dbf591900807e4b6d6f1647cd94c10e55b
kmymoney/plugins/kbanking/widgets/chiptandialog.ui cb51402923d396852e765e85b8794e9ee59f2ddd
Diff: https://git.reviewboard.kde.org/r/126536/diff/
Testing
-------
Successfully build without qtquick1 installed.
Thanks,
Heiko Becker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160111/f9be18fb/attachment.html>
More information about the KMyMoney-devel
mailing list