[Kmymoney-devel] Review Request 126536: kbanking: Fix build without qtquick1

[Christian David]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126536/#review90892
-----------------------------------------------------------

Ship it!


Ship It!

- Christian David


On Dez. 27, 2015, 4:26 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126536/
> -----------------------------------------------------------
> 
> (Updated Dez. 27, 2015, 4:26 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> This accidentally worked when I still had qtquick1 installed. Without
> it the build fails with "ui_chiptandialog.h:13:42: fatal error:
> QtDeclarative/QDeclarativeView: No such file or directory".
> The build system doesn't search for it and isn't really necessary
> anymore so I removed the unused <class> part from chiptandialog.ui and
>  used the appropriate enum from QtQuickWidgets.
> 
> 
> Diffs
> -----
> 
>   kmymoney/plugins/kbanking/widgets/chiptandialog.cpp c2d683dbf591900807e4b6d6f1647cd94c10e55b 
>   kmymoney/plugins/kbanking/widgets/chiptandialog.ui cb51402923d396852e765e85b8794e9ee59f2ddd 
> 
> Diff: https://git.reviewboard.kde.org/r/126536/diff/
> 
> 
> Testing
> -------
> 
> Successfully build without qtquick1 installed.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160111/a95198e5/attachment.html>