Review Request 127556: Quit application if all windows were closed, refactor main()

Christian David christian-david at web.de
Tue Apr 26 20:07:13 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127556/#review94877
-----------------------------------------------------------


Ship it!




Ship It!

- Christian David


On April 2, 2016, 8:37 p.m., Christian David wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127556/
> -----------------------------------------------------------
> 
> (Updated April 2, 2016, 8:37 p.m.)
> 
> 
> Review request for KMymoney and Cristian OneČ›.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Allow QApplication to quit if all windows were closed. Otherwise
> KMyMoney would never shut down.
> 
> Used this commit for minor changes which simplify the code.
> 
> Most important is the removal of ```app.setQuitOnLastWindowClosed(false);```. Is there a reason why it was added?
> 
> 
> Diffs
> -----
> 
>   kmymoney/kmymoney.cpp 0d0a317d753e9c48740180d13235163928687b2c 
>   kmymoney/main.cpp cf77030aeb7de0f744bc2cf928514568d564e2e8 
> 
> Diff: https://git.reviewboard.kde.org/r/127556/diff/
> 
> 
> Testing
> -------
> 
> Started and closed the app.
> 
> 
> Thanks,
> 
> Christian David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20160426/eea9f02f/attachment.html>


More information about the KMyMoney-devel mailing list