[Kmymoney-devel] [kmymoney4] [Bug 353372] New: OFX files are double encoded which messes up the £ sign

[Barry Scott]

https://bugs.kde.org/show_bug.cgi?id=353372

            Bug ID: 353372
           Summary: OFX files are double encoded which messes up the £
                    sign
           Product: kmymoney4
           Version: 4.7.1
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: kmymoney-devel at kde.org
          Reporter: barry at barrys-emacs.org

OFX import over HTTP/HTTPS downloads data in CP1252 typically.
This is assumed, in error, to be unicode by the OFX import code and saved into
a tempfile
encoded as UTF-8.
The UTF-8 encoded tempfile is passed into libofx to parse.
libofx assumes that the encoding is exactly as describer by the OFX headers.
It then uses iconv to convert from the declated encoding of CP1252 into utf-8
ready to pass to OFX imported code.

You can see this problem with an OFX file that contains a £ sign.
After import it shows as two characters.

The attached patch fixes two places I found that this mistake.


Reproducible: Always

Steps to Reproduce:
1. Import an OFX file encoded in CP1252 that containing:
          <STMTTRN>
            <TRNTYPE>OTHER
            <DTPOSTED>20150803000000[-5:EST]
            <TRNAMT>0.04
            <FITID>+201508030000001            
            <NAME>INT EARNED £0.05LESS TAX £0.01IN
          </STMTTRN>
2. See that the Ledger entry is: INT EARNED £0.05LESS TAX £0.01IN


Actual Results:  
£ is shown as £

Expected Results:  
Show £ as £

-- 
You are receiving this mail because:
You are the assignee for the bug.