[Kmymoney-devel] Review Request 121288: Database version is set after creating tables

[Christian David]

> On Nov. 29, 2014, 10:33 vorm., Christian David wrote:
> > kmymoney/mymoney/storage/mymoneystoragesql.cpp, line 740
> > <https://git.reviewboard.kde.org/r/121288/diff/1/?file=331058#file331058line740>
> >
> >     This is still an open issue: ```m_storage->fileFixVersion()``` was never set before - so it just contains junk.
> >     
> >     But it is not really set anywhere else. The database driver just uses ```m_storage->fileFixVersion()``` to write it to the database and ```m_storage->setFileFixVersion()``` is only called with the version which was stored in the database.
> 
> Christian David wrote:
>     I guess nobody has any idea (anymore)?!

Seems that fixVersion is not used by the backends at all - KMyMoneyView::initializeStorage() uses it :)


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121288/#review71073
-----------------------------------------------------------


On Jan. 4, 2015, 3:13 nachm., Christian David wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121288/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2015, 3:13 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> So the upgrade routine is not executed starting from version 0 - which
> is useless as the database should be the most recent version anyway.
> 
> Also removed the version param from createTables(int version). It was
> not used and was totaly useless as createTables() calls upgradeDb().
> 
> This is also a workaround for bug 341304 as the upgradeToV1() won't be
> called after creation of tables anymore. The bug persists if the user
> has a version 0 database.
> 
> CCBUG: 341304
> REVIEW: 121288
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp 80ff5a725e41e2a344cf32019b22803059ab9f93 
>   kmymoney/mymoney/storage/mymoneystoragesql.h ae79b484186e700367f9a4362ffd19772825cf22 
>   kmymoney/mymoney/storage/mymoneystoragesql.cpp 3b82d2b45623ed0e4d3e8cba7e6dc7364ed50f9e 
> 
> Diff: https://git.reviewboard.kde.org/r/121288/diff/
> 
> 
> Testing
> -------
> 
> make test
> 
> only one fail left (see comments)
> 
> XFAIL  : MyMoneyDatabaseMgrTest::testBadConnections() Will fix when correct behaviour in this case is clear.
>    Loc: [/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(106)]
> 
> 
> Thanks,
> 
> Christian David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150110/64daebce/attachment.html>