[Kmymoney-devel] Review Request 121288: Database version is set after creating tables

Fernando Vilas fvilas at iname.com
Tue Jan 6 03:15:10 UTC 2015


On Sunday, January 4, 2015 02:18:07 PM Christian David wrote:
> > On Nov. 29, 2014, 10:33 vorm., Christian David wrote:
> > > kmymoney/mymoney/storage/mymoneystoragesql.cpp, line 740
> > > <https://git.reviewboard.kde.org/r/121288/diff/1/?file=331058#file331058
> > > line740>> > 
> > >     This is still an open issue: ```m_storage->fileFixVersion()``` was
> > >     never set before - so it just contains junk.
> > >     
> > >     But it is not really set anywhere else. The database driver just
> > >     uses ```m_storage->fileFixVersion()``` to write it to the database
> > >     and ```m_storage->setFileFixVersion()``` is only called with the
> > >     version which was stored in the database.
> I guess nobody has any idea (anymore)?!
> 

Not really, sorry....  it's been way too long since I looked at that part of 
the code.

You already have the TODO for the test captured as a separate bug, so if you 
are happy with the other results, I would say ship it.

Thanks,
Fernando



More information about the KMyMoney-devel mailing list