[Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121803/#review73056
-----------------------------------------------------------


One cannot change the label in the KScheduledView ctor() as the label is created delayed due to virtual functions being used (see comment at http://lxr.kde.org/source/kde/kdelibs/kdeui/itemviews/ktreewidgetsearchline.cpp line 584).

Another spot to make the change is in KScheduledView::slotRearrange() which is called early enough. This will then have to look like:

void KScheduledView::slotRearrange(void)
{
  // set an alternative label text inside the search line widget
  QLabel* label = m_searchWidget->findChild<QLabel*>();
  if(label) {
    label->setText(i18nc("Filter widget label", "Fi&lter:"));
  }

  resizeEvent(0);
}

Hope that helps.

- Thomas Baumgart


On Jan. 3, 2015, 2:28 nachm., Christian David wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121803/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2015, 2:28 nachm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 338296
>     http://bugs.kde.org/show_bug.cgi?id=338296
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> The field is actually more filter than search.
> 
> This also fixes the bug "In Ledger: Keyboard shortcut for Search (Alt-E)
> does not work".
> 
> I could not change the label in scheduled transactions view because it
> is hard coded in the library. But this should be done as well. Shall we wait with this request until it is done there as well?
> 
> BUG: 338296
> FIXED-IN: 4.7.2
> 
> 
> Diffs
> -----
> 
>   kmymoney/widgets/registersearchline.cpp cae7a3fa22bf5ccd559ebeefc12885bff8d1051d 
> 
> Diff: https://git.reviewboard.kde.org/r/121803/diff/
> 
> 
> Testing
> -------
> 
> Opened with english local and tested shortcut. Works fine.
> 
> 
> Thanks,
> 
> Christian David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150104/aab53588/attachment.html>