[Kmymoney-devel] Review Request 121803: Changed label for serach bar in ledger from "Search" to "Filter"

Christian David christian-david at web.de
Sat Jan 3 13:28:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121803/
-----------------------------------------------------------

(Updated Jan. 3, 2015, 2:28 nachm.)


Review request for KMymoney.


Changes
-------

Added reason why I made a review request for such a change.


Bugs: 338296
    http://bugs.kde.org/show_bug.cgi?id=338296


Repository: kmymoney


Description (updated)
-------

The field is actually more filter than search.

This also fixes the bug "In Ledger: Keyboard shortcut for Search (Alt-E)
does not work".

I could not change the label in scheduled transactions view because it
is hard coded in the library. But this should be done as well. Shall we wait with this request until it is done there as well?

BUG: 338296
FIXED-IN: 4.7.2


Diffs
-----

  kmymoney/widgets/registersearchline.cpp cae7a3fa22bf5ccd559ebeefc12885bff8d1051d 

Diff: https://git.reviewboard.kde.org/r/121803/diff/


Testing
-------

Opened with english local and tested shortcut. Works fine.


Thanks,

Christian David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150103/22943907/attachment.html>


More information about the KMyMoney-devel mailing list