[Kmymoney-devel] Review Request 122746: Add a stage to the consistency check to fix transaction post dates.

Cristian Oneț onet.cristian at gmail.com
Mon Apr 6 08:24:15 UTC 2015



> On April 6, 2015, 6:44 a.m., Thomas Baumgart wrote:
> > kmymoney/dialogs/transactioneditor.cpp, line 678
> > <https://git.reviewboard.kde.org/r/122746/diff/5/?file=356770#file356770line678>
> >
> >     Why do you change 'Sell' to 'Add'? AFAIR, adding and removing shares does not involve a price. Please check by using the UI.
> 
> Cristian Oneț wrote:
>     I've changed this because the action() of the split will never have the value "Sell" AFAICS. Take a look at mymoneysplit.cpp for a list of possible actions. Judging by the intended action the list should be "Buy", "Add", "Reinvest". I agree though that I should have mentioned the reason behind this action.
> 
> Thomas Baumgart wrote:
>     You're right, 'Sell' does not exist since it is handled as a 'Buy with negative value' ;) In that case, we should remove the 'Sell'/'Add' condition completely. One does not exist and the other does not make sense here.

Could you elaborate on why "Add" does not make sense here? The condition skips splits for which a price entry should not be added, does an "Add" split need a price entry?


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122746/#review78548
-----------------------------------------------------------


On March 27, 2015, 6:29 a.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122746/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 6:29 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 313793
>     http://bugs.kde.org/show_bug.cgi?id=313793
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> If the transaction is moved to another post date the price information
> is moved along with it for investments transactions. This fixes the
> reported issue, saving the file once will fix all price issues.
> 
> Also add the possibility to save the consistency check log to a file
> or copy it into the clipboard.
> 
> Make sure that the user enters a valid transaction date by checking
> that the transaction date is after the opening date of each and every
> account involved in the transaction. Until now we only checked that
> the transaction date is after the opening date of the account in which
> is being entered.
> 
> BUG: 313793
> REVIEW: 122746
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/transactioneditor.cpp a215e3f8a1eaf2f7ccf1d73f29190f2ad86ff282 
>   kmymoney/kmymoney.h 92ab4b28d52c237222a2fb1106398ce0208215aa 
>   kmymoney/kmymoney.cpp c132983b63536e094375532082ea87c54461235c 
>   kmymoney/mymoney/mymoneyfile.cpp 8c1be4301a89b65f428edf2b8f0ab8b6e3dac51e 
> 
> Diff: https://git.reviewboard.kde.org/r/122746/diff/
> 
> 
> Testing
> -------
> 
> Opened the file attached to the report and observe that the consistency check fixes all of the issues.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150406/b209a0a2/attachment.html>


More information about the KMyMoney-devel mailing list