[Kmymoney-devel] Review Request 122746: Add a stage to the consistency check to fix transaction post dates.

[Thomas Baumgart]

> On April 6, 2015, 8:44 vorm., Thomas Baumgart wrote:
> >
> 
> Cristian Oneț wrote:
>     Thomas, if you have the feeling that moving the transaction's date is not the right way feel free to make that staement :). I'm not sure either about this patch but it's a way forward for the reported bug, I agree that if the transaction dates are correct and the account dates are wrong this could cause a lot of work for the user. So we might as well just drop this patch.

Well, I think it is a solution to the problem which should not arise in the first place. But that is a different story.


> On April 6, 2015, 8:44 vorm., Thomas Baumgart wrote:
> > kmymoney/dialogs/transactioneditor.cpp, line 678
> > <https://git.reviewboard.kde.org/r/122746/diff/5/?file=356770#file356770line678>
> >
> >     Why do you change 'Sell' to 'Add'? AFAIR, adding and removing shares does not involve a price. Please check by using the UI.
> 
> Cristian Oneț wrote:
>     I've changed this because the action() of the split will never have the value "Sell" AFAICS. Take a look at mymoneysplit.cpp for a list of possible actions. Judging by the intended action the list should be "Buy", "Add", "Reinvest". I agree though that I should have mentioned the reason behind this action.

You're right, 'Sell' does not exist since it is handled as a 'Buy with negative value' ;) In that case, we should remove the 'Sell'/'Add' condition completely. One does not exist and the other does not make sense here.


> On April 6, 2015, 8:44 vorm., Thomas Baumgart wrote:
> > kmymoney/mymoney/mymoneyfile.cpp, line 2138
> > <https://git.reviewboard.kde.org/r/122746/diff/5/?file=356773#file356773line2138>
> >
> >     Same as above about Add vs. Sell.
> 
> Cristian Oneț wrote:
>     See above.

Please remove the 'Add' condition here as well. See above.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122746/#review78548
-----------------------------------------------------------


On März 27, 2015, 7:29 vorm., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122746/
> -----------------------------------------------------------
> 
> (Updated März 27, 2015, 7:29 vorm.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 313793
>     http://bugs.kde.org/show_bug.cgi?id=313793
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> If the transaction is moved to another post date the price information
> is moved along with it for investments transactions. This fixes the
> reported issue, saving the file once will fix all price issues.
> 
> Also add the possibility to save the consistency check log to a file
> or copy it into the clipboard.
> 
> Make sure that the user enters a valid transaction date by checking
> that the transaction date is after the opening date of each and every
> account involved in the transaction. Until now we only checked that
> the transaction date is after the opening date of the account in which
> is being entered.
> 
> BUG: 313793
> REVIEW: 122746
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/transactioneditor.cpp a215e3f8a1eaf2f7ccf1d73f29190f2ad86ff282 
>   kmymoney/kmymoney.h 92ab4b28d52c237222a2fb1106398ce0208215aa 
>   kmymoney/kmymoney.cpp c132983b63536e094375532082ea87c54461235c 
>   kmymoney/mymoney/mymoneyfile.cpp 8c1be4301a89b65f428edf2b8f0ab8b6e3dac51e 
> 
> Diff: https://git.reviewboard.kde.org/r/122746/diff/
> 
> 
> Testing
> -------
> 
> Opened the file attached to the report and observe that the consistency check fixes all of the issues.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20150406/9aba5106/attachment-0001.html>