[Kmymoney-devel] Review Request 120377: Added emitting of signal in KMyMoneyAccountCombo::setSelected()

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120377/#review67851
-----------------------------------------------------------

Ship it!


Since I guess no one can tell if this will cause problems but you can confirm that it fixes issues it just seems sensible to ship it.

- Cristian Oneț


On Sept. 26, 2014, 8:48 a.m., Christian David wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120377/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 8:48 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> The accountSelected(QString) signal is emitted if
> KMyMoneyAccountCombo::setSelected() is used to change the selection.
> This should be the behavior expected by any user of this signal.
> 
> The name "accountSelected" could be meant as "account selected by user". Could someone with a better understanding of the internals tell me if my change does not cause any issues.
> 
> Also: are there other ways to change selection which do not emit this signal?
> 
> Btw:?This is the most elegant solution of some issues in the credit transfer editors.
> 
> 
> Diffs
> -----
> 
>   kmymoney/widgets/kmymoneyaccountcombo.cpp bde7d9b9935e82e714a74a41bfcfa426d045066a 
> 
> Diff: https://git.reviewboard.kde.org/r/120377/diff/
> 
> 
> Testing
> -------
> 
> In a short test I could not find any disadvantages.
> 
> 
> Thanks,
> 
> Christian David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20141003/2ddad13f/attachment.html>