[Kmymoney-devel] Review Request 110212: Add Merge Payee Option

[Felipe Tonello]

> On March 2, 2014, 6:39 a.m., Thomas Baumgart wrote:
> > kmymoney/kmymoney.cpp, line 946
> > <https://git.reviewboard.kde.org/r/110212/diff/2/?file=244058#file244058line946>
> >
> >     Please make sure to align all new icons with the work Alvaro just added to the master branch.

Yes. This "merge" icon is part of Oxygen already.


> On March 2, 2014, 6:39 a.m., Thomas Baumgart wrote:
> > kmymoney/kmymoney.cpp, line 4742
> > <https://git.reviewboard.kde.org/r/110212/diff/2/?file=244058#file244058line4742>
> >
> >     I am not sure, why you duplicate payee_id into newPayeeName here.

This was my mistake since slotPayeeNew() first argument is const anyway. So there is no problem in having both of the references pointing to the same address. I will fix this and update this pull request.


- Felipe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110212/#review51654
-----------------------------------------------------------


On Feb. 14, 2014, 6:06 p.m., Felipe Tonello wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110212/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 6:06 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> It implements Payee Merge operation.
> 
> To be able to make this I had to change KPayeeReassignDlg to support other operations then delete. Also I used the delete payee slot and created a new function since merge and delete operations are very similar, avoiding code duplication.
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/kpayeereassigndlg.h a348d2b9fdc68a7c56a616a862a3373ef35aa0ba 
>   kmymoney/dialogs/kpayeereassigndlg.cpp 8bdb25c0b3478c42715fac9f052903ed45b3614c 
>   kmymoney/dialogs/kpayeereassigndlgdecl.ui 2cf563d4ea755e8d89ff2587fa677f14453cbaa5 
>   kmymoney/kmymoney.h 56e0bd6a3de42bdaa3fbb2f8586495cbb4d555ca 
>   kmymoney/kmymoney.cpp 426ddc93962a4d44e42301c146e90c648c96c035 
>   kmymoney/kmymoneyui.rc 65afc920cef7091e3138c9acf75f73ec96929445 
>   kmymoney/views/kpayeesview.h c747e691f6509c7bf60201dfb3cc77e9f939a7c5 
>   kmymoney/views/kpayeesview.cpp 69697e6f34505c597cacd97f6516fbdaf708f4ae 
>   kmymoney/views/kpayeesviewdecl.ui 6efb2ae5f94383851ee2ab15da36187b7079815a 
> 
> Diff: https://git.reviewboard.kde.org/r/110212/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felipe Tonello
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140310/d573b677/attachment.html>