<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110212/">https://git.reviewboard.kde.org/r/110212/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 2nd, 2014, 6:39 a.m. PST, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/110212/diff/2/?file=244058#file244058line946" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/kmymoney.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KMyMoneyApp::initActions(void)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">946</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> payee_merge->setIcon(KIcon("merge"));</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please make sure to align all new icons with the work Alvaro just added to the master branch.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. This "merge" icon is part of Oxygen already.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 2nd, 2014, 6:39 a.m. PST, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/110212/diff/2/?file=244058#file244058line4742" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/kmymoney.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KMyMoneyApp::slotPayeeDelete(void)</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KMyMoneyApp::payeeReassign(int type)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4729</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> QString newPayeeName(payee_id);</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not sure, why you duplicate payee_id into newPayeeName here. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This was my mistake since slotPayeeNew() first argument is const anyway. So there is no problem in having both of the references pointing to the same address. I will fix this and update this pull request.</pre>
<br />
<p>- Felipe</p>
<br />
<p>On February 14th, 2014, 6:06 p.m. PST, Felipe Tonello wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Felipe Tonello.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2014, 6:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It implements Payee Merge operation.
To be able to make this I had to change KPayeeReassignDlg to support other operations then delete. Also I used the delete payee slot and created a new function since merge and delete operations are very similar, avoiding code duplication.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/kpayeereassigndlg.h <span style="color: grey">(a348d2b9fdc68a7c56a616a862a3373ef35aa0ba)</span></li>
<li>kmymoney/dialogs/kpayeereassigndlg.cpp <span style="color: grey">(8bdb25c0b3478c42715fac9f052903ed45b3614c)</span></li>
<li>kmymoney/dialogs/kpayeereassigndlgdecl.ui <span style="color: grey">(2cf563d4ea755e8d89ff2587fa677f14453cbaa5)</span></li>
<li>kmymoney/kmymoney.h <span style="color: grey">(56e0bd6a3de42bdaa3fbb2f8586495cbb4d555ca)</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(426ddc93962a4d44e42301c146e90c648c96c035)</span></li>
<li>kmymoney/kmymoneyui.rc <span style="color: grey">(65afc920cef7091e3138c9acf75f73ec96929445)</span></li>
<li>kmymoney/views/kpayeesview.h <span style="color: grey">(c747e691f6509c7bf60201dfb3cc77e9f939a7c5)</span></li>
<li>kmymoney/views/kpayeesview.cpp <span style="color: grey">(69697e6f34505c597cacd97f6516fbdaf708f4ae)</span></li>
<li>kmymoney/views/kpayeesviewdecl.ui <span style="color: grey">(6efb2ae5f94383851ee2ab15da36187b7079815a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110212/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>