[Kmymoney-devel] Review Request 118107: Calculate cleared balance in core

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118107/
-----------------------------------------------------------

(Updated June 1, 2014, 9:57 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney.


Repository: kmymoney


Description
-------

It calculates cleared balance for an account in MyMoneyFile, instead of doing it in the ledger view (kgloballedgerview.cpp)

I'm posting it here because I'm a bit concerned on the performance it may have for everyday use.
I'm keen on optimizing, but this kind of code should be removed from the views in the long-term.


Diffs
-----

  kmymoney/mymoney/mymoneyfile.h 3a39ba0 
  kmymoney/mymoney/mymoneyfile.cpp 4f6d277 
  kmymoney/views/kgloballedgerview.cpp d2d626c 

Diff: https://git.reviewboard.kde.org/r/118107/diff/


Testing
-------

I tested with a small file. It works ok. I still have to add a unit test for it.


Thanks,

Alvaro Soliverez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140601/6ef6694b/attachment.html>