[Kmymoney-devel] Frameworks

[Cristian Oneț]

2014-07-16 10:21 GMT+03:00 Cristian Oneț <onet.cristian at gmail.com>:
> 2014-07-16 10:09 GMT+03:00 Marko Käning <mk-lists at email.de>:
>> Hi Cristian,
>>
>> On 16 Jul 2014, at 06:53 , Cristian Oneț <onet.cristian at gmail.com> wrote:
>>> Those are libraries from kdepimlibs and should be handled by adding
>>> kdepimlibs[frameworks] as a dependency.
>>
>> yes, I know. I’ve taken care of this in [1] just now.
>
> Thanks,
>
>>
>>
>>>> ... I hope you can help to fix a problem I met on OSX with the alkimia build system
>>>>
>>>> Ben pointed this out:
>>>>
>>>> ---
>>>>
>>>> On 15 Jul 2014, at 12:50 , Ben Cooksley <bcooksley at kde.org> wrote:
>>>>> This is a fairly usual split-installation-prefix build failure then :)
>>>>> You need to ask the libalkimia developers to adjust the CMake code to
>>>>> ensure the GMP include paths are added to include_directories()
>>>>> appropriately.
>>
>>
>> Cristian, any idea about this ^^^ ?
>
> I'll fix this, I thought [1] is enough (add gmp to
> target_link_libraries) but I guess that it's true only for frameworks.
> AFAIK adding used frameworks to the include directories is not
> necessary since this is deduced from target_link_libraries in cmake 3,
> please correct me if this is wrong.

Done

http://commits.kde.org/alkimia/7fe269fae63d0b5786ee8953460e8e0faf564fb5

Regards,
Cristian

>
> Regards,
> Cristian
>
> [1] https://projects.kde.org/projects/extragear/office/alkimia/repository/revisions/master/entry/libalkimia/CMakeLists.txt#L67
>
>>
>> Greets,
>> Marko
>>
>>
>>
>>
>> [1] https://git.reviewboard.kde.org/r/119308/