[Kmymoney-devel] [kmymoney4] [Bug 336258] Crash while editing a split

Cristian Oneț onet.cristian at gmail.com
Sun Aug 31 16:22:14 UTC 2014


Cristian Oneț <onet.cristian at gmail.com> changed:

           What    |Removed                     |Added
      Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
                   |oney/8e7898fbd7de4cc7557d5d |oney/f3d666d93dbcb2f0b51a34
                   |e9eaae32386d2859b1          |4ab2d78f7c68c92c67

--- Comment #5 from Cristian Oneț <onet.cristian at gmail.com> ---
Git commit f3d666d93dbcb2f0b51a344ab2d78f7c68c92c67 by Cristian Oneț.
Committed on 31/08/2014 at 15:49.
Pushed by conet into branch 'frameworks'.

Fix a nasty split editor bug.

Because of the way the endEdit method was written the endEdit
operation could be executed without actually ending the edit
(missing category). But code that was calling endEdit expected
that it allways would end the edit thus sometimes edit widgets
could be obtained on two rows.

Once in this state accepting both editors would cause a crash.

Also removed a workaround which would end the edit on a resize.
Instead don't do the operation that was resizing the rows while
in edit.
(cherry picked from commit 8e7898fbd7de4cc7557d5de9eaae32386d2859b1)


M  +24   -21   kmymoney/dialogs/kmymoneysplittable.cpp
M  +9    -1    kmymoney/dialogs/kmymoneysplittable.h


You are receiving this mail because:
You are the assignee for the bug.

More information about the KMyMoney-devel mailing list