[Kmymoney-devel] Review Request 119911: Updated extraction code to support "Financial Times UK Funds" source for online price quotes

[Ian Neal]

Hi David,

The one I had a problem with is GB00B1XG9607

Probably a configuration problem at the FT end, as it resolves to 
GB00B1XG9607:GBP but is displayed as a GBX and if you try 
GB00B1XG9607:GBX it fails to find it.

There may be others with this issue, but it is trying to fix that one 
that I managed to stumble across just having the URL end in %1

Regards,

Ian

On 23/08/14 14:42, David Houlden wrote:
> OK, I've had a look at this now.
>
> The change as submitted by Thomas does not work for me because of the
> :GBP on the end. This should be :GBX which is what I have been using for
> several months now. From my limited testing It does seem that removing
> :GBP and having the URL end in %1 also works.
>
> I would be interested to know about any ISIN codes which do not work as
> described above.
>
> Ian, I would be interested to know the ISIN code of the fund you say
> only works without a currency in the URL.
>
> Regards,
> David
>
> On Saturday 23 August 2014 13:47:50 Ian Neal wrote:
>> Hi Allan,
>>
>> Does it work with just:
>> http://funds.ft.com/uk/Tearsheet/Summary?s=%1
>>
>> so not using either of:
>> http://funds.ft.com/uk/Tearsheet/Summary?s=%1:GBP
>> or
>> http://funds.ft.com/uk/Tearsheet/Summary?s=%1:GBX
>>
>> Regards,
>>
>> Ian
>>
>> On 23/08/14 13:40, Allan wrote:
>>> On 23/08/14 13:15, Ian Neal wrote:
>>>> Hi Allan,
>>>>
>>>> Does it work any better with no symbol at the end, i.e.:
>>>>
>>>> http://funds.ft.com/uk/Tearsheet/Summary?s=%1
>>>>
>>>> At least one of my investments only works with configured that way.
>>>>
>>>> Ian
>>> Hi Neal
>>>
>>> It works with the ':GBX' suffix after the url, or after the symbol,
>>> but not both.
>>>
>>> 'GBP' appears not to work at all.
>>>
>>> Allan
>>>
>>>> On 23/08/14 12:11, Allan wrote:
>>>>> On 23/08/14 12:05, David Houlden wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> It was me that sent this change to Thomas. I just checked and I
>>>>>> have
>>>>>> subsequently made another change to the URL. My version now has
>>>>>> GBX
>>>>>> instead of GBP. If you can give me a while I will check Thomas's
>>>>>> patch to verify it works for me as I am using that source for
>>>>>> prices. Bit busy
>>>>>> just now but will get back to you later.
>>>>>>
>>>>>> David.
>>>>> I've just created a new investment.  I've tried both the new and
>>>>> the
>>>>> old versions, and neither works for me.
>>>>>
>>>>> Allan
>>>>>
>>>>>> On Saturday 23 August 2014 10:52:36 Cristian Oneț wrote:
>>>>>>
>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>> https://git.reviewboard.kde.org/r/119911/
>>>>>>
>>>>>>
>>>>>> On August 23rd, 2014, 10:43 a.m. UTC, Cristian Onețwrote:
>>>>>>
>>>>>> Ship It!
>>>>>>
>>>>>> On August 23rd, 2014, 10:44 a.m. UTC, Cristian Onețwrote:
>>>>>>
>>>>>> Although the currency symbol could be made configurable in the
>>>>>> URL.
>>>>>> For
>>>>>> fund in euro, like
>>>>>> http://funds.ft.com/uk/Tearsheet/Summary?s=ES0102562032:EUR
>>>>>>
>>>>>> On August 23rd, 2014, 10:49 a.m. UTC, Thomas Baumgartwrote:
>>>>>>
>>>>>> Right, but we only have the symbol of the security. This is
>>>>>> something
>>>>>> the user must take care of, since we don't know which currency to
>>>>>> use at
>>>>>> this point. Also, this is a completely different URL.
>>>>>>
>>>>>> OK, then ship it :).
>>>>>>
>>>>>>
>>>>>> - Cristian
>>>>>>
>>>>>> On August 23rd, 2014, 10:40 a.m. UTC, Thomas Baumgart wrote:
>>>>>>
>>>>>> Review request for KMymoney.
>>>>>>
>>>>>> By Thomas Baumgart.
>>>>>>
>>>>>> Updated Aug. 23, 2014, 10:40 a.m.
>>>>>>
>>>>>> Repository: kmymoney
>>>>>>
>>>>>> Description
>>>>>>
>>>>>> This patch shall support "Financial Times UK Funds" as source for
>>>>>> online
>>>>>> price quotes again. Apparently their format changed. I received
>>>>>> this
>>>>>> patch a long time ago via e-mail and just found it sitting in my
>>>>>> stash.
>>>>>> Before I add it to master, I wanted someone to review it.
>>>>>>
>>>>>> Testing
>>>>>>
>>>>>> Compile, Link, Run the application but no testing towards the new
>>>>>> source
>>>>>>
>>>>>> Diffs
>>>>>>
>>>>>>    * kmymoney/converter/webpricequote.cpp (7b1d24d)
>>>>>>
>>>>>> View Diff <https://git.reviewboard.kde.org/r/119911/diff/>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> KMyMoney-devel mailing list
>>>>>> KMyMoney-devel at kde.org
>>>>>> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>>>>> _______________________________________________
>>>>> KMyMoney-devel mailing list
>>>>> KMyMoney-devel at kde.org
>>>>> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>> _______________________________________________
>> KMyMoney-devel mailing list
>> KMyMoney-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/kmymoney-devel
> _______________________________________________
> KMyMoney-devel mailing list
> KMyMoney-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel