[Kmymoney-devel] Review Request 115941: Allow date filtering in the ledger.

[Thomas Baumgart]

> On Feb. 22, 2014, 12:06 a.m., Alvaro Soliverez wrote:
> > kmymoney/widgets/dateintervalselector.cpp, line 158
> > <https://git.reviewboard.kde.org/r/115941/diff/1/?file=245410#file245410line158>
> >
> >     I think this should be None. The same for the enum
> 
> Cristian Oneț wrote:
>     I chose "don't care' since it's about a time interval described with "when" which seems to match "don't care" better then "none" but a native English speaker could help us here.

Did you see Jack's comment who suggest 'Any date' which I think is what we should use. Make sure to give a translation hint towards 'No date filter selected'.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115941/#review50491
-----------------------------------------------------------


On Feb. 21, 2014, 8:09 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115941/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 8:09 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Bugs: 257436
>     http://bugs.kde.org/show_bug.cgi?id=257436
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Allow date filtering in the ledger.
> 
> This currently works as the quick search filter meaning that when
> it's active the balance will not be displayed.
> 
> FEATURE: 257436
> 
> Posted the review to get some feedback if this would be the right way to do this.
> If it is I would prefer loading only the matching transactions (using the interval in the transaction filter) so that the balance can be displayed correctly inside the interval.
> 
> 
> Diffs
> -----
> 
>   kmymoney/widgets/CMakeLists.txt 9a6cdebe465e6c79d3ec62fb2268377d492373f8 
>   kmymoney/widgets/dateintervalselector.h PRE-CREATION 
>   kmymoney/widgets/dateintervalselector.cpp PRE-CREATION 
>   kmymoney/widgets/registeritem.h cccf2d7f5a2cc5127bdc248c644e2a68051c7dc9 
>   kmymoney/widgets/registersearchline.h 40b5427059457cdc1acba0888289c134adb59e00 
>   kmymoney/widgets/registersearchline.cpp 810a5b66ec99058b39362b6e8c6a9a471dacc6ec 
>   kmymoney/widgets/transaction.cpp 1cb6eb339b171cb88429ac6869f50e66a4285b48 
> 
> Diff: https://git.reviewboard.kde.org/r/115941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140819/5a4fbcae/attachment.html>