<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115941/">https://git.reviewboard.kde.org/r/115941/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 22nd, 2014, 12:06 a.m. CET, <b>Alvaro Soliverez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115941/diff/1/?file=245410#file245410line158" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/widgets/dateintervalselector.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">158</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">addItem</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span class="s">"value in the date interval combo"</span><span class="p">,</span> <span class="s">"Don't care"</span><span class="p">),</span> <span class="n">enDontCare</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this should be None. The same for the enum</pre>
</blockquote>
<p>On February 24th, 2014, 6:27 p.m. CET, <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I chose "don't care' since it's about a time interval described with "when" which seems to match "don't care" better then "none" but a native English speaker could help us here.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you see Jack's comment who suggest 'Any date' which I think is what we should use. Make sure to give a translation hint towards 'No date filter selected'.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On February 21st, 2014, 8:09 p.m. CET, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2014, 8:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=257436">257436</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allow date filtering in the ledger.
This currently works as the quick search filter meaning that when
it's active the balance will not be displayed.
FEATURE: 257436
Posted the review to get some feedback if this would be the right way to do this.
If it is I would prefer loading only the matching transactions (using the interval in the transaction filter) so that the balance can be displayed correctly inside the interval.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/widgets/CMakeLists.txt <span style="color: grey">(9a6cdebe465e6c79d3ec62fb2268377d492373f8)</span></li>
<li>kmymoney/widgets/dateintervalselector.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/widgets/dateintervalselector.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/widgets/registeritem.h <span style="color: grey">(cccf2d7f5a2cc5127bdc248c644e2a68051c7dc9)</span></li>
<li>kmymoney/widgets/registersearchline.h <span style="color: grey">(40b5427059457cdc1acba0888289c134adb59e00)</span></li>
<li>kmymoney/widgets/registersearchline.cpp <span style="color: grey">(810a5b66ec99058b39362b6e8c6a9a471dacc6ec)</span></li>
<li>kmymoney/widgets/transaction.cpp <span style="color: grey">(1cb6eb339b171cb88429ac6869f50e66a4285b48)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115941/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>