[Kmymoney-devel] Review Request 119639: Moved several widgets from the static into the shared library

Christian David christian-david at web.de
Thu Aug 7 07:15:39 UTC 2014

This is an automatically generated e-mail. To reply, visit:

Review request for KMymoney.

Repository: kmymoney


This patch is part of my effort to merge master and add-onlinebanking.

Affected are the classes
KMyMoneyMVCCombo and several derived classes

and some helper classes.

Export macros are now generated by cmake.

This patch should make it easier to develop plugins which use KMyMoney's widgets.

Some more classes should be moved into the shared library as well but this is not so easy. I guess I have to understand more of what is going on. Also this makes the problem that the library for QtDesigner cannot be compiled even worse – but if the move from a static to the shared library is continued it will be easier to fix the designer problems.


  kmymoney/widgets/kmymoneyedit.h 96fd811285b8951387c8248ddc3e7b08d051d6b1 
  kmymoney/CMakeLists.txt fdd80faa54558da1c44908a7c8dff8c1baed3435 
  kmymoney/dialogs/CMakeLists.txt 2e933e0a26309fb78bb87fd78795091961b499b6 
  kmymoney/widgets/CMakeLists.txt c444558b27e056eef1065befb9cfc5e0e4c07244 
  kmymoney/widgets/kguiutils.h aa194f65856d6c2c2914631cd110bb8546c76e0b 
  kmymoney/widgets/kmm_widgets_export.h 19275cce2d07b90a756f9222f23a6d347a7fce97 
  kmymoney/widgets/kmymoneycalculator.h 68cd4b82a30207e215cc3ddfc237e5c3187c7de1 
  kmymoney/widgets/kmymoneylineedit.h b95f6441e362813bfbd373b6b7c9cb60ac354978 
  kmymoney/widgets/kmymoneymvccombo.h a9d8e37ee0a600240c7ca4544964a448770d0a24 
  kmymoney/widgets/kmymoneyselector.h 6b3d65b1fa4632581fc9d2ddc7a26575aaba9a1a 

Diff: https://git.reviewboard.kde.org/r/119639/diff/


KMyMoney still compiles and everything looks normal.


Christian David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140807/8f774689/attachment.html>

More information about the KMyMoney-devel mailing list