<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119639/">https://git.reviewboard.kde.org/r/119639/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Christian David.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is part of my effort to merge master and add-onlinebanking.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Affected are the classes<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
kMandatoryFieldGroup<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
kMyMoneyCalculator<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
kMyMoneyEdit<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
kMyMoneyLineEdit<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
KMyMoneyMVCCombo and several derived classes<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
KMyMoneySelector</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and some helper classes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Export macros are now generated by cmake.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch should make it easier to develop plugins which use KMyMoney's widgets.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some more classes should be moved into the shared library as well but this is not so easy. I guess I have to understand more of what is going on. Also this makes the problem that the library for QtDesigner cannot be compiled even worse – but if the move from a static to the shared library is continued it will be easier to fix the designer problems.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KMyMoney still compiles and everything looks normal.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/widgets/kmymoneyedit.h <span style="color: grey">(96fd811285b8951387c8248ddc3e7b08d051d6b1)</span></li>
<li>kmymoney/CMakeLists.txt <span style="color: grey">(fdd80faa54558da1c44908a7c8dff8c1baed3435)</span></li>
<li>kmymoney/dialogs/CMakeLists.txt <span style="color: grey">(2e933e0a26309fb78bb87fd78795091961b499b6)</span></li>
<li>kmymoney/widgets/CMakeLists.txt <span style="color: grey">(c444558b27e056eef1065befb9cfc5e0e4c07244)</span></li>
<li>kmymoney/widgets/kguiutils.h <span style="color: grey">(aa194f65856d6c2c2914631cd110bb8546c76e0b)</span></li>
<li>kmymoney/widgets/kmm_widgets_export.h <span style="color: grey">(19275cce2d07b90a756f9222f23a6d347a7fce97)</span></li>
<li>kmymoney/widgets/kmymoneycalculator.h <span style="color: grey">(68cd4b82a30207e215cc3ddfc237e5c3187c7de1)</span></li>
<li>kmymoney/widgets/kmymoneylineedit.h <span style="color: grey">(b95f6441e362813bfbd373b6b7c9cb60ac354978)</span></li>
<li>kmymoney/widgets/kmymoneymvccombo.h <span style="color: grey">(a9d8e37ee0a600240c7ca4544964a448770d0a24)</span></li>
<li>kmymoney/widgets/kmymoneyselector.h <span style="color: grey">(6b3d65b1fa4632581fc9d2ddc7a26575aaba9a1a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119639/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>