[Kmymoney-devel] csvimport crash on multiple import

[Chris]

Ok. You got me!

Will need to remove the "select file" button from the intermediate pages.

When stepping through the settings, the last pages buttons are a bit 
confusing you are presented with a finish button and import csv button. I 
think you should have one or the other not both. A couple of times I have 
automatically clicked finish expecting it to import the selected file.

I also have noted clicking on the cancel button brings up a dialogue that 
looks like it wants to shutdown kmymoney rather than just close the wizard. 
I don't think you need a warning to close the wizard and it is confusing. No 
data is lost when closing it, so pressing the cancel button should simply 
close the wizard.

Chris



On 24/04/2014 2:13 AM, Allan wrote:
> On 23/04/14 13:26, Chris wrote:
>> Hi Allan
>>
>> Hmm looks like my attempt at ascii art failed
>>
>> Three seperate csv imports one after the other without quitting the
>> import dialogue. The third file gets locked in a loop and eventually
>> crashes
>>
>> Each import uses the same settings, with the skip setting checkbox
>> marked, when I select the third file it never gets to the stage of
>> asking for the bank account.
>>
>> The loop is as I have shown below
>>
>> initializePage() => m_dlg->m_pageLinesDate->validatePage() =>
>> slotImportClicked() => wizard()->next() => validatePage() and then back
>> to slotImportClicked()
>>
>> Always on the third file even when importing different files (same
>> format though)
>>
>> I have attached a series of screen grabs which show various stages. I
>> think the clue to whats going on is in the 9th image. The import is
>> starting on a different wizard page than the first two.
>>
>> Look carefully at the images and you will see clicking the "select file"
>> button occurs on a different wizard page each time. Remember I am not
>> cancelling/closing the wizard in between imports.
>>
>> Capture10 is what you see before the crash occurs. because the wizard is
>> looping it cannot redraw the screen and therefore is just a white box
>>
>> I have skipped capturing some steps. They should be fairly obvious.
>>
>> Chris
>
> Hi Chris
>
> Ah, I see you fell into my little trap!
>
> Look at shot 7.  Having completed the first import, if you wish to 
> proceed, you should click Back, which is perhaps a bit misleading.  You 
> should not click Select File - I've not yet looked at that.  Clicking Back 
> at this point takes a short cut to the beginning without going via the 
> intermediate pages, and you can now select the next file and all then 
> follows on in sequence.
>
> I think at the shot 7 stage, if you don't wish to do a further import, you 
> should get an option to bail out, not as it shows, select another file.
>
> If I too do what you did, I get a segmentation fault.
>
> Apologies for that.
>
> Allan
>
>
>> On 23/04/2014 3:30 AM, Allan wrote:
>>> On 22/04/14 14:24, Chris wrote:
>>>>
>>>> I find that when importing 3 banking csv files consecutively with the
>>>> skip setup button checked, kmymoney crashes.
>>>>
>>>> A loop is occuring which eventually exhausts resources.
>>>>
>>>> initializePage() calls m_dlg->m_pageLinesDate->validatePage();
>>>>    which calls m_dlg->m_pageCompletion->slotimportclicked()
>>>>    ==>    which calls wizard()->next()
>>>> // which calls validatePage()
>>>> ||which calls slotImportClicked()  = ||
>>>> \\=================================================//
>>>>
>>>>
>>>> This is the code where the loop occurs in LinesDatePage::validatePage()
>>>>
>>>>      if ((m_dlg->m_pageIntro->ui->checkBoxSkipSetup->isChecked())) {
>>>>        if (m_dlg->m_importError) {
>>>>          wizard()->next();
>>>>        } else {
>>>>          m_dlg->m_pageCompletion->slotImportClicked(); <== loops
>>>>        }
>>>>      }
>>>>
>>>> I have no idea why this occurs on the third import, it may just be
>>>> coincidental.
>>>>
>>>> Chris
>>>
>>> A test here, importing the same file into the same folder three times,
>>> worked for me, so I think we need a bit more information.
>>>
>>> When you say it loops, presumably you are intervening to select the
>>> files?  Or, did it all loop without intervention
>>>
>>> I don't suppose you were re-importing the same file, but, for
>>> simplicity, could you try that?  If it fails, can you give a step by
>>> step description of what you did and what happened at each stage.  If
>>> it doesn't fail, is there anything different about the third file?
>>>
>>> Allan
>>>
>>>
>>> _______________________________________________
>>> KMyMoney-devel mailing list
>>> KMyMoney-devel at kde.org
>>> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>>>
>>>
>>
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Capture12.JPG
Type: image/jpeg
Size: 21117 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140424/dbe550dd/attachment-0002.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Capture13.JPG
Type: image/jpeg
Size: 17491 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140424/dbe550dd/attachment-0003.jpe>