[Kmymoney-devel] Review Request 117620: Remove fixed layout values from the CSV importer UI.

[Chris]

Ok I see at some stage in the recent past a patch was put in for the 
incorrect indexing of the cell which was causing the crashes

       if (ui->tableWidget->item(row, col) == 0) {  //  cell does not exist
         continue;
       }

Chris


On 18/04/2014 6:53 AM, Cristian Oneț wrote:
> This is an automatically generated e-mail. To reply, visit: 
> https://git.reviewboard.kde.org/r/117620/
>
>
> Review request for KMymoney and Allan Anderson.
> By Cristian Oneț.
> *Repository: * kmymoney
>
>
>   Description
>
> Remove fixed layout values from the CSV importer UI.
>
> Also removed a lot of code (a lot still remains) that I think should
> not be in there (like UI control size fine tuning).
>
>
>   Testing
>
> For me the importer looks/feel almost like without this.
>
>
>   Diffs
>
>   * kmymoney/plugins/csvimport/bankingwizardpage.ui
>     (d2179bff0504a67a22efbb364f90e089443d8239)
>   * kmymoney/plugins/csvimport/completionwizardpage.ui
>     (99db07576265b68c764308bbb3da3cae38b151bd)
>   * kmymoney/plugins/csvimport/csvdialog.h
>     (6716ca412db036384d9d8d65f0d1ab40efbe443f)
>   * kmymoney/plugins/csvimport/csvdialog.cpp
>     (3ab7f9537acdb369b0c5b781827564e30d9ad396)
>   * kmymoney/plugins/csvimport/csvdialog.ui
>     (36e7fd51159a1f7391394b5f00bc22387b0bd8f5)
>   * kmymoney/plugins/csvimport/csvimporterplugin.h
>     (d2d2f6ca9aeea0709512afcffbad17abea6a315a)
>   * kmymoney/plugins/csvimport/csvimporterplugin.cpp
>     (602b4d924c8afc0b34819e47b03b88776319bf0c)
>   * kmymoney/plugins/csvimport/introwizardpage.ui
>     (9bd29f5f4339add8790e032f5613ec46c675634d)
>   * kmymoney/plugins/csvimport/investmentwizardpage.ui
>     (3744963e5e9a91ad36b8d0fa78839b296c5810f8)
>   * kmymoney/plugins/csvimport/investprocessing.cpp
>     (d9df90d6b9a6500b499e52ccb3e8734d163765eb)
>   * kmymoney/plugins/csvimport/lines-datewizardpage.ui
>     (fb10a0e228d7bdee9ca1162edcd0d4b69225d68b)
>   * kmymoney/plugins/csvimport/separatorwizardpage.ui
>     (30b2dc7b22ad24b7b2df96332deb25f9c8c76b89)
>
> View Diff <https://git.reviewboard.kde.org/r/117620/diff/>
>
>
>
> _______________________________________________
> KMyMoney-devel mailing list
> KMyMoney-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20140418/e2f390bb/attachment.html>