<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
Ok I see at some stage in the recent past a patch was put in for the
incorrect indexing of the cell which was causing the crashes<br>
<br>
if (ui->tableWidget->item(row, col) == 0) { // cell
does not exist<br>
continue;<br>
}<br>
<br>
Chris<br>
<br>
<br>
<div class="moz-cite-prefix">On 18/04/2014 6:53 AM, Cristian Oneț
wrote:<br>
</div>
<blockquote cite="mid:20140417212315.3409.9815@probe.kde.org"
type="cite">
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table style="border: 1px #c9c399 solid;" width="100%"
bgcolor="#f9f3c9" cellpadding="8">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To reply,
visit: <a moz-do-not-send="true"
href="https://git.reviewboard.kde.org/r/117620/">https://git.reviewboard.kde.org/r/117620/</a>
</td>
</tr>
</tbody>
</table>
<br>
<table style="background-image:
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');
background-position: left top; background-repeat: repeat-x;
border: 1px black solid;" width="100%" bgcolor="#fefadf"
cellpadding="8" cellspacing="0">
<tbody>
<tr>
<td>
<div>Review request for KMymoney and Allan Anderson.</div>
<div>By Cristian Oneț.</div>
<div style="margin-top: 1.5em;"> <b style="color:
#575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Description </h1>
<table style="border: 1px solid #b8b5a0" width="100%"
bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove fixed layout values from the CSV importer UI.
Also removed a lot of code (a lot still remains) that I think should
not be in there (like UI control size fine tuning).</pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Testing </h1>
<table style="border: 1px solid #b8b5a0" width="100%"
bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For me the importer looks/feel almost like without this.</pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/bankingwizardpage.ui <span
style="color: grey">(d2179bff0504a67a22efbb364f90e089443d8239)</span></li>
<li>kmymoney/plugins/csvimport/completionwizardpage.ui
<span style="color: grey">(99db07576265b68c764308bbb3da3cae38b151bd)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.h <span
style="color: grey">(6716ca412db036384d9d8d65f0d1ab40efbe443f)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span
style="color: grey">(3ab7f9537acdb369b0c5b781827564e30d9ad396)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.ui <span
style="color: grey">(36e7fd51159a1f7391394b5f00bc22387b0bd8f5)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.h <span
style="color: grey">(d2d2f6ca9aeea0709512afcffbad17abea6a315a)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.cpp <span
style="color: grey">(602b4d924c8afc0b34819e47b03b88776319bf0c)</span></li>
<li>kmymoney/plugins/csvimport/introwizardpage.ui <span
style="color: grey">(9bd29f5f4339add8790e032f5613ec46c675634d)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.ui
<span style="color: grey">(3744963e5e9a91ad36b8d0fa78839b296c5810f8)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span
style="color: grey">(d9df90d6b9a6500b499e52ccb3e8734d163765eb)</span></li>
<li>kmymoney/plugins/csvimport/lines-datewizardpage.ui
<span style="color: grey">(fb10a0e228d7bdee9ca1162edcd0d4b69225d68b)</span></li>
<li>kmymoney/plugins/csvimport/separatorwizardpage.ui
<span style="color: grey">(30b2dc7b22ad24b7b2df96332deb25f9c8c76b89)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="https://git.reviewboard.kde.org/r/117620/diff/"
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
KMyMoney-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:KMyMoney-devel@kde.org">KMyMoney-devel@kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/kmymoney-devel">https://mail.kde.org/mailman/listinfo/kmymoney-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>