[Kmymoney-devel] csv importer new compile

Mon Apr 14 09:20:32 UTC 2014

Cool

Looking forward to that patch too.

Allan did you get that stuff I sent you about compiling on XP?

Chris

On 14/04/2014 2:38 AM, Allan wrote:
> On 13/04/14 17:52, Cristian Oneț wrote:
>> Hi,
>>
>> I'm preparing to deliver a kind of monthly packaging of git master on
>> Windows so I finally got a look into this and can tell you the following:
>>
>> Style has absolutely nothing to do with this bug. The problem is the fact
>> that the CSV importer layout contains a bunch of fixed sizes (mostly
>> vertical) which prevent the buttons from being visible if the actual height
>> that is needed to render the data does not fit into these fixed sizes.
>>
>> Once I've removed some fixed vertical sizes from the layout the importer
>> started to look as expected. I will provide a patch for this.
>>
>> Regards,
>> Cristian
>
> OK, Cristian
>
> That's interesting, so I'll look forward to seeing your patch.
>
> Allan
>
>> 2014-04-11 20:59 GMT+03:00 Allan <agander93 at gmail.com>:
>>
>>> On 11/04/14 16:13, Chris wrote:
>>>
>>>> I tried it in kubuntu and it seems fine to me.everything works as
>>>> expected.
>>>>
>>>> On windows the problem is with the aero theme. If I change the style to
>>>> classic. It works as expected.
>>>>
>>>> I added the following code to csvdialog.cpp
>>>>
>>>>     m_wizard = new QWizard;
>>>>     m_wizard->setWizardStyle(QWizard::ClassicStyle); <== added this line
>>>>     ui->horizontalLayout->insertWidget(2, m_wizard, 0);
>>>>
>>>> I don't know why the aero theme does not work.
>>>>
>>>> Chris
>>>>
>>>
>>>
>>> Well done, that man!  It definitely had the smell of a style issue, but I
>>> hadn't sussed that I could dictate it.
>>>
>>> I tried the different styles and in fact your Aero worked without trouble
>>> although no other looked right.  The MacStyle was a no-go.
>>>
>>> Glad that's sorted.  I just need to do the finishing off with the
>>> scrolling and resizing now.
>>>
>>> Allan
>>>
>>>
>>>
>>>> On 11/04/2014 7:39 AM, Allan wrote:
>>>>
>>>>> On 10/04/14 13:52, Chris wrote:
>>>>>
>>>>>> You are spot on!
>>>>>>
>>>>>> It was the whitespace on windows that was causing the issue. I added
>>>>>> --ignore-whitespace and the patch applied flawlessly
>>>>>>
>>>>>> Unfortunately it made very little difference in windows. I haven't tried
>>>>>> kubuntu yet, I will do so tomorrow.
>>>>>>
>>>>>> One thing that I have found. if I click and drag the "title bar" just
>>>>>> above the introwizard I can drag the introwizard into a better position
>>>>>> and the select file and cancel buttons become accessible.
>>>>>>
>>>>>> My guess based on that observation is the title bar which is supposed to
>>>>>> be hidden is not being hidden and this is pushing the introwizard down.
>>>>>>
>>>>>
>>>>> The title bar isn't supposed to be hidden.  It shouldn't be there at
>>>>> all. The introwizard is a QtWidget, which has a title bar, but the
>>>>> widget itself doesn't get loaded into the importer dialog widget.
>>>>> Instead, it has a horizontal layout which does not include the title
>>>>> bar.  The layout instead gets inserted into another layout in the
>>>>> importer.
>>>>>
>>>>> Also, your screen-shot shows that the title is CSV Importer, which is
>>>>> not the name of the widget, but the importer dialog's name. So, I can
>>>>> only see it being a Windows 'feature'.
>>>>>
>>>>>>
>>>>>> I have also noticed the "extra" title bar just below the main dialogue
>>>>>> title bar, disappears when you change the radio button selections and
>>>>>> the small notifier dialog pops up.
>>>>>>
>>>>>> This also appears to be a problem with that dialogue not being properly
>>>>>> hidden. Once it is moved to the center and brought to the front the
>>>>>> extra graphic then hides properly.
>>>>>>
>>>>>> Does that make sense. If not I can include some images to show you what
>>>>>> I am talking about
>>>>>>
>>>>>>
>>>>>> Chris
>>>>>>
>>>>>
>>>>> I think a couple of images might help me visualise it.
>>>>>
>>>>> Allan
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>> On 10/04/2014 7:56 PM, Allan wrote:
>>>>>>
>>>>>>> On 10/04/14 09:50, Chris wrote:
>>>>>>>
>>>>>>>> Hi Allan Thank you for that
>>>>>>>>
>>>>>>>> I get errors when I tried to apply the patch. I thought I might be
>>>>>>>> behind so I pulled in the latest master but it results in the same
>>>>>>>> errors it seems you might be patching a commit or branch I don't have.
>>>>>>>>
>>>>>>>> git apply --check
>>>>>>>> 0001-Modify-CSV-importer-settings-and-UI-to-correct-appea.patch
>>>>>>>> error: patch failed: kmymoney/plugins/csvimport/
>>>>>>>> bankingwizardpage.ui:6
>>>>>>>> error: kmymoney/plugins/csvimport/bankingwizardpage.ui: patch does
>>>>>>>> not
>>>>>>>> apply
>>>>>>>> error: patch failed: kmymoney/plugins/csvimport/csvdialog.cpp:105
>>>>>>>> error: kmymoney/plugins/csvimport/csvdialog.cpp: patch does not apply
>>>>>>>> error: patch failed: kmymoney/plugins/csvimport/csvdialog.h:168
>>>>>>>> error: kmymoney/plugins/csvimport/csvdialog.h: patch does not apply
>>>>>>>> error: patch failed: kmymoney/plugins/csvimport/introwizardpage.ui:48
>>>>>>>> error: kmymoney/plugins/csvimport/introwizardpage.ui: patch does not
>>>>>>>> apply
>>>>>>>> error: patch failed:
>>>>>>>> kmymoney/plugins/csvimport/investmentwizardpage.ui:6
>>>>>>>> error: kmymoney/plugins/csvimport/investmentwizardpage.ui: patch does
>>>>>>>> not apply
>>>>>>>>
>>>>>>>> I also was doing some testing last night and I found the layout errors
>>>>>>>> change between builds. I have seen this sort of error before. Often it
>>>>>>>> is the result of a un-initialised variable. I also realised I may have
>>>>>>>> another issue. for no particular reason I have been building
>>>>>>>> kmymoney as
>>>>>>>> 32bit app perhaps the behaviour I am seeing is an improperly
>>>>>>>> initialised
>>>>>>>> int or a pointer problem due to the change in word length.
>>>>>>>>
>>>>>>>> Just guesswork so far I haven't committed to recompiling the entire
>>>>>>>> library as 64bit yet to test it
>>>>>>>>
>>>>>>>> Chris
>>>>>>>>
>>>>>>>
>>>>>>> Hi Chris
>>>>>>>
>>>>>>> That's strange.  All five files failed?!!  I can't see it being a
>>>>>>> commit problem.  Nobody else has worked on them, at least for a couple
>>>>>>> of years, so they should be in step.
>>>>>>>
>>>>>>> I wonder if you tried on Windows rather that Ubuntu? I produced them
>>>>>>> under Ubuntu, and for all files to fail, I'm wondering if you were on
>>>>>>> Windows, and whether it's a line-ending problem, which would affect
>>>>>>> all the files, of course.
>>>>>>>
>>>>>>> I hadn't really thought about that previously, but I guess the file
>>>>>>> will need to be edited for Windows.  There are only three lines which
>>>>>>> affect the immediate performance of the plugin, those at line 149-151
>>>>>>> in csvdialog.cpp, if you wanted to see to what extent, or if, they
>>>>>>> might help or change your issue.
>>>>>>>
>>>>>>> Allan
>>>>>>>
>>>>>>>
>>>>>>> Allan
>>>>>>>
>>>>>>>   On 8/04/2014 9:48 PM, Allan wrote:
>>>>>>>>
>>>>>>>>> Hi Chris
>>>>>>>>>
>>>>>>>>> Here's the patch for you to try.  For me, it looks OK on Ubuntu now,
>>>>>>>>> so should be OK for you, too.  Windows, we'll see if it helps, but I
>>>>>>>>> can't see it making any difference so far as the Title bars are
>>>>>>>>> concerned.
>>>>>>>>>
>>>>>>>>> Let's know how it goes.  There are some outstanding issues with
>>>>>>>>> scrolling and resizing.  I'm pretty close with those but didn't want
>>>>>>>>> to make more changes until this first lot is tried.
>>>>>>>>>
>>>>>>>>> Allan
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>
> _______________________________________________
> KMyMoney-devel mailing list
> KMyMoney-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel