[Kmymoney-devel] Review Request 113011: Add VAT split to file import.

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113011/#review43440
-----------------------------------------------------------



kmymoney/mymoney/mymoneytransaction.cpp
<http://git.reviewboard.kde.org/r/113011/#comment31268>

    MyMoneyTransaction should not use anything from MyMoneyFile.



kmymoney/mymoney/mymoneytransaction.cpp
<http://git.reviewboard.kde.org/r/113011/#comment31267>

    Please move this kind of logic to MyMoneyFile. MyMoneyTransaction should not use anything from MyMoneyFile. Possible signature:
    
      bool MyMoneyFile::addVATSplit(MyMoneyTransaction&, const MyMoneyAccount& account, const MyMoneyAccount& category, const MyMoneyMoney& amount);
    


- Thomas Baumgart


On Nov. 9, 2013, 11:38 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113011/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2013, 11:38 p.m.)
> 
> 
> Review request for KMymoney and Cristian Oneț.
> 
> 
> Bugs: 241322
>     http://bugs.kde.org/show_bug.cgi?id=241322
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> Add VAT split to file import.
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneystatementreader.cpp f41b0cfe079c0c5238b43c56c66ea216d028901a 
>   kmymoney/dialogs/transactioneditor.cpp cfb0f71b255e948dcbda7a2b57178da44cc7d0b4 
>   kmymoney/mymoney/mymoneytransaction.h 9dc18151c8cc540f71ebc5cdc1a818168212e610 
>   kmymoney/mymoney/mymoneytransaction.cpp fdb0618f18bb21b0663d3a4985aae1239d0e7bc6 
> 
> Diff: http://git.reviewboard.kde.org/r/113011/diff/
> 
> 
> Testing
> -------
> 
> 1. created new kmymoney file using skr03 standard accounts 
> 2. enable "VAT account" account 1775 "Umsatzsteuer 19%" and entered 19 as vat percents
> 3. added account 1775 as automatic vat assignment accounts to account 8400 "Erlöse"
> 4. added payee "Warenverkauf" with auto assignment to account 8400 
> 5. imported some transactions from csv file for account 1200 "Bankkonto" using the payee defined in step 4.
> date,nr,expense,income,payee
> 14.02.2012,2,,"259,99",Warenverkauf
> 25.03.2012,3,,"49,99",Warenverkauf
> 25.06.2012,4,,"709,99",Warenverkauf
> 
> Afterwards ledger contains transactions with correct vat split.
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20131111/da9e921f/attachment-0001.html>