<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113011/">http://git.reviewboard.kde.org/r/113011/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113011/diff/1/?file=193226#file193226line25" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/mymoney/mymoneytransaction.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <mymoneyfile.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">MyMoneyTransaction should not use anything from MyMoneyFile.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113011/diff/1/?file=193226#file193226line131" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/mymoney/mymoneytransaction.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">130</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">bool</span> <span class="n">MyMoneyTransaction</span><span class="o">::</span><span class="n">addVATSplit</span><span class="p">(</span><span class="k">const</span> <span class="n">MyMoneyAccount</span> <span class="o">&</span><span class="n">account</span><span class="p">,</span> <span class="k">const</span> <span class="n">MyMoneyAccount</span> <span class="o">&</span><span class="n">category</span><span class="p">,</span> <span class="k">const</span> <span class="n">MyMoneyMoney</span> <span class="o">&</span><span class="n">amount</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please move this kind of logic to MyMoneyFile. MyMoneyTransaction should not use anything from MyMoneyFile. Possible signature:
bool MyMoneyFile::addVATSplit(MyMoneyTransaction&, const MyMoneyAccount& account, const MyMoneyAccount& category, const MyMoneyMoney& amount);
</pre>
</div>
<br />
<p>- Thomas Baumgart</p>
<br />
<p>On November 9th, 2013, 11:38 p.m. CET, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Cristian Oneț.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2013, 11:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=241322">241322</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add VAT split to file import.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. created new kmymoney file using skr03 standard accounts
2. enable "VAT account" account 1775 "Umsatzsteuer 19%" and entered 19 as vat percents
3. added account 1775 as automatic vat assignment accounts to account 8400 "Erlöse"
4. added payee "Warenverkauf" with auto assignment to account 8400
5. imported some transactions from csv file for account 1200 "Bankkonto" using the payee defined in step 4.
date,nr,expense,income,payee
14.02.2012,2,,"259,99",Warenverkauf
25.03.2012,3,,"49,99",Warenverkauf
25.06.2012,4,,"709,99",Warenverkauf
Afterwards ledger contains transactions with correct vat split.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/converter/mymoneystatementreader.cpp <span style="color: grey">(f41b0cfe079c0c5238b43c56c66ea216d028901a)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(cfb0f71b255e948dcbda7a2b57178da44cc7d0b4)</span></li>
<li>kmymoney/mymoney/mymoneytransaction.h <span style="color: grey">(9dc18151c8cc540f71ebc5cdc1a818168212e610)</span></li>
<li>kmymoney/mymoney/mymoneytransaction.cpp <span style="color: grey">(fdb0618f18bb21b0663d3a4985aae1239d0e7bc6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113011/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>