[Kmymoney-devel] Review Request 109043: Fix various problems where the Enter button is enabled prematurely, or not enabled when it was required. Enable tabs when in multi-transaction edit with transaction form.

[Allan Anderson]

> On March 4, 2013, 12:51 p.m., Allan Anderson wrote:
> > Might someone have a chance to look at this, please?  Thanks.
> 
> Allan Anderson wrote:
>     Retesting this issue has revealed a loophole, when the transaction form is not in use and the amount is entered last.  I'll do some more testing then produce a new patch.
> 
> Marko Käning wrote:
>     Actually it is not clear to me in what case the transaction form is not in use...
>     
>     How do you want to edit anything without the transaction form. Obviously I am missing something here.

In Kmm Settings/Ledger, there is an option 'Show transaction form', which normally I leave unchecked, to allow more transactions to be shown.  So, instead, editing a transaction is done within the temporarily expanded body of the transaction.

The difference this made to the problem, was that instead of having a single amount field, there are the two columns of the register, Payment and Deposit.  In the original code, there was no mechanism for changes to Payment or Deposit to update the button status.  So, in my original patch, I hadn't noticed this and the amount change was not triggering a call to StdTransactionEditor::isComplete().  However, amount->value().isZero() was found to be false during a pass through StdTransactionEditor::isComplete(), but only if the Payment or Deposit change was not the last change made.

I'm not sure if this is what you were asking, so I've given a bit more of the rationale, just in case.


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109043/#review28541
-----------------------------------------------------------


On Feb. 19, 2013, 5:27 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109043/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 5:27 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> When not using the transaction form, it is possible to enter just an amount, and immediately the Enter button becomes enabled.  This is not the case when using the transaction form. The Enter button only becomes enabled when other fields are added.
> 
> Some other discrepancies also were noticed, both when using the transaction form, and when not.
> 
> 1a) Enter a payee. That's OK.
> 1b) Now enter a single character in the memo.  Enter enabled.
> 2a) Enter a memo character. That's OK.
> 2b) Now enter a payee. That's still OK.
> 2c) Now enter another memo character.  Enter enabled.
> 3a) Enter an account.    Enter enabled.
> 4a) Enter a tag.    Enter enabled.
> 
> Also, when using the transaction form and doing a multi-transaction edit, on attempting to enter an amount, it was not accepted unless the amount was negative.
> In the same area, the tabs are not enabled.
> 
> Investment entry seems OK. 
> 
> 
> This addresses bug 314955.
>     http://bugs.kde.org/show_bug.cgi?id=314955
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/transactioneditor.cpp a6d7432 
>   kmymoney/widgets/register.cpp c167bcd 
> 
> Diff: http://git.reviewboard.kde.org/r/109043/diff/
> 
> 
> Testing
> -------
> 
> Performed numerous edits both with and without the transaction form, and single and multiple transactions.  Imports of QIF and CSV files done.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130307/da01205c/attachment-0001.html>