<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109043/">http://git.reviewboard.kde.org/r/109043/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 4th, 2013, 12:51 p.m. UTC, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Might someone have a chance to look at this, please? Thanks.</pre>
</blockquote>
<p>On March 7th, 2013, 4:42 p.m. UTC, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Retesting this issue has revealed a loophole, when the transaction form is not in use and the amount is entered last. I'll do some more testing then produce a new patch.</pre>
</blockquote>
<p>On March 7th, 2013, 9:54 p.m. UTC, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually it is not clear to me in what case the transaction form is not in use...
How do you want to edit anything without the transaction form. Obviously I am missing something here.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In Kmm Settings/Ledger, there is an option 'Show transaction form', which normally I leave unchecked, to allow more transactions to be shown. So, instead, editing a transaction is done within the temporarily expanded body of the transaction.
The difference this made to the problem, was that instead of having a single amount field, there are the two columns of the register, Payment and Deposit. In the original code, there was no mechanism for changes to Payment or Deposit to update the button status. So, in my original patch, I hadn't noticed this and the amount change was not triggering a call to StdTransactionEditor::isComplete(). However, amount->value().isZero() was found to be false during a pass through StdTransactionEditor::isComplete(), but only if the Payment or Deposit change was not the last change made.
I'm not sure if this is what you were asking, so I've given a bit more of the rationale, just in case.
</pre>
<br />
<p>- Allan</p>
<br />
<p>On February 19th, 2013, 5:27 p.m. UTC, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2013, 5:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When not using the transaction form, it is possible to enter just an amount, and immediately the Enter button becomes enabled. This is not the case when using the transaction form. The Enter button only becomes enabled when other fields are added.
Some other discrepancies also were noticed, both when using the transaction form, and when not.
1a) Enter a payee. That's OK.
1b) Now enter a single character in the memo. Enter enabled.
2a) Enter a memo character. That's OK.
2b) Now enter a payee. That's still OK.
2c) Now enter another memo character. Enter enabled.
3a) Enter an account. Enter enabled.
4a) Enter a tag. Enter enabled.
Also, when using the transaction form and doing a multi-transaction edit, on attempting to enter an amount, it was not accepted unless the amount was negative.
In the same area, the tabs are not enabled.
Investment entry seems OK. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Performed numerous edits both with and without the transaction form, and single and multiple transactions. Imports of QIF and CSV files done.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=314955">314955</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(a6d7432)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(c167bcd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109043/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>