[Kmymoney-devel] Review Request 107797: BUG:213250 - Fix QIF Import creating unneeded brokerage accounts.

[Allan Anderson]

> On Jan. 14, 2013, 6:41 a.m., Thomas Baumgart wrote:
> > Looks good to me and certainly makes sense.

There was a problem, I discovered.  I had been using small QIF files to check/test particular issues and all worked well.  However, I later discovered that with a large file from Quicken, containing multiple accounts, statements were getting imported into the account following the one into which they should have have been.
I had to remove a single statement which I'd initially inserted near the end of - 
const QString MyMoneyQifReader::processAccountEntry(bool resetAccountId)-
line 2047   "d->st.m_accountId = acc.id();  //                            needed here"
which was causing the problem.

I can't now remember why I inserted that line in the first place, but probably some issue I'd discovered was subsequently resolved differently.  acc.id() had picked up the id of the newly created following account, and was causing the problem.

Previous tests were repeated.

astyle run.

All looks good to go ahead now.


- Allan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107797/#review25422
-----------------------------------------------------------


On Dec. 23, 2012, 12:11 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107797/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2012, 12:11 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> When importing a QIF file which contains investment accounts, a Brokerage account is created for each account, even if the transactions include a name for the investment account to be used. This is because the Brokerage account is created when the investment account line is encountered, and before the start of the transactions processing.  If several accounts are being imported, this creates a lot of clutter.
> The change delays the decision on Brokerage account creation until transaction processing occurs.
> 
> 
> This addresses bug 213250.
>     http://bugs.kde.org/show_bug.cgi?id=213250
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneyqifreader.h c103dc0 
>   kmymoney/converter/mymoneyqifreader.cpp d535091 
> 
> Diff: http://git.reviewboard.kde.org/r/107797/diff/
> 
> 
> Testing
> -------
> 
> Tested successfully with a number of different QIF files.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130116/00f603a3/attachment.html>