[Kmymoney-devel] Review Request 107797: BUG:213250 - Fix QIF Import creating unneeded brokerage accounts.

Thomas Baumgart thb at net-bembel.de
Mon Jan 14 06:41:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107797/#review25422
-----------------------------------------------------------

Ship it!


Looks good to me and certainly makes sense.


kmymoney/converter/mymoneyqifreader.cpp
<http://git.reviewboard.kde.org/r/107797/#comment19441>

    Please check indentation (or run astyle) before you commit


- Thomas Baumgart


On Dec. 23, 2012, 12:11 p.m., Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107797/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2012, 12:11 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> When importing a QIF file which contains investment accounts, a Brokerage account is created for each account, even if the transactions include a name for the investment account to be used. This is because the Brokerage account is created when the investment account line is encountered, and before the start of the transactions processing.  If several accounts are being imported, this creates a lot of clutter.
> The change delays the decision on Brokerage account creation until transaction processing occurs.
> 
> 
> This addresses bug 213250.
>     http://bugs.kde.org/show_bug.cgi?id=213250
> 
> 
> Diffs
> -----
> 
>   kmymoney/converter/mymoneyqifreader.h c103dc0 
>   kmymoney/converter/mymoneyqifreader.cpp d535091 
> 
> Diff: http://git.reviewboard.kde.org/r/107797/diff/
> 
> 
> Testing
> -------
> 
> Tested successfully with a number of different QIF files.
> 
> 
> Thanks,
> 
> Allan Anderson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130114/fb18a4f9/attachment-0001.html>


More information about the KMyMoney-devel mailing list