[Kmymoney-devel] Review Request: Display the number of not marked transactions for every account on KMM's homepage

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108150/#review24948
-----------------------------------------------------------



kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/108150/#comment19126>

    I am completely and utterly puzzled right now. For some reason this code doesn't build anymore (as I believe it did yesterday):
    
    [ 77%] Building CXX object kmymoney/mymoney/CMakeFiles/mymoneyfiletest.dir/mymoneyfiletest.cpp.o
    /Users/marko/WC/GIT/kmymoney.homeview-additional_columns/kmymoney/mymoney/mymoneyfiletest.cpp: In member function ‘void MyMoneyFileTest::testCountNotReconciledTransactions()’:
    /Users/marko/WC/GIT/kmymoney.homeview-additional_columns/kmymoney/mymoney/mymoneyfiletest.cpp:2118: error: ‘class MyMoneyTransaction’ has no member named ‘setState’
    /Users/marko/WC/GIT/kmymoney.homeview-additional_columns/kmymoney/mymoney/mymoneyfiletest.cpp:2118: error: ‘MyMoneyCheckingTransaction’ has not been declared
    make[2]: *** [kmymoney/mymoney/CMakeFiles/mymoneyfiletest.dir/mymoneyfiletest.cpp.o] Error 1
    make[1]: *** [kmymoney/mymoney/CMakeFiles/mymoneyfiletest.dir/all] Error 2
    make: *** [all] Error 2
    
    Was I working for some reason in another build directory when running this test successfully?
    
    Only now I see that the t.setState()-call appears only twice in comments made by Thomas and in my function.


- Marko Käning


On Jan. 6, 2013, 8:25 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108150/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 8:25 p.m.)
> 
> 
> Review request for KMymoney and Łukasz Maszczyński.
> 
> 
> Description
> -------
> 
> This patch introduces new columns in the accounts tables on KMM's homepage (similar to [1]) which will list the number of not marked transactions for each specific account.
> 
> This information will give the user the chance to immediately spot accounts which aren't properly looked after.
> 
> 
> ---
> [1] "homepage: extend accounts table with additional columns to reflect online-status" https://git.reviewboard.kde.org/r/107364/
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/settings/ksettingshomedecl.ui 4cb36cced4801f5d6ecf35ef84f375a629cd8792 
>   kmymoney/kmymoney.kcfg a60ccad153385c961fa15c5b0964588c14e7ad89 
>   kmymoney/mymoney/mymoneyfile.h c43977ce7413eee2bc1e0a841fa548314c71e9df 
>   kmymoney/mymoney/mymoneyfile.cpp 6640356d5e07152f8eb4aecff23d62ee8d853dbd 
>   kmymoney/mymoney/mymoneyfiletest.h 5551fa94b6b34022c8e91c0301847d5479e6b1f2 
>   kmymoney/mymoney/mymoneyfiletest.cpp feb9d57ecd7156fc1eea189a905fa797aeae9183 
>   kmymoney/views/khomeview.cpp c79337176b7265cabe15cad4972bc719e797af7c 
> 
> Diff: http://git.reviewboard.kde.org/r/108150/diff/
> 
> 
> Testing
> -------
> 
> Builds and runs fine.
> 
> TODO:
>  - implement tests for MyMoneyFile::countNotReconciledTransactions(const QString& accId)
> 
> 
> Screenshots
> -----------
> 
> accounts tables with the additional column for the number of not reconciled transactions
>   http://git.reviewboard.kde.org/r/108150/s/985/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130107/f4a03045/attachment.html>