<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108150/">http://git.reviewboard.kde.org/r/108150/</a>
     </td>
    </tr>
   </table>
   <br />









<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/108150/diff/3/?file=105316#file105316line2118" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/mymoney/mymoneyfiletest.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MyMoneyFileTest::testCountNotReconciledTransactions()</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2118</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">  <span class="n">t</span><span class="p">.</span><span class="n">setState</span><span class="p">(</span><span class="n">MyMoneyCheckingTransaction</span><span class="o">::</span><span class="n">Cleared</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am completely and utterly puzzled right now. For some reason this code doesn't build anymore (as I believe it did yesterday):

[ 77%] Building CXX object kmymoney/mymoney/CMakeFiles/mymoneyfiletest.dir/mymoneyfiletest.cpp.o
/Users/marko/WC/GIT/kmymoney.homeview-additional_columns/kmymoney/mymoney/mymoneyfiletest.cpp: In member function ‘void MyMoneyFileTest::testCountNotReconciledTransactions()’:
/Users/marko/WC/GIT/kmymoney.homeview-additional_columns/kmymoney/mymoney/mymoneyfiletest.cpp:2118: error: ‘class MyMoneyTransaction’ has no member named ‘setState’
/Users/marko/WC/GIT/kmymoney.homeview-additional_columns/kmymoney/mymoney/mymoneyfiletest.cpp:2118: error: ‘MyMoneyCheckingTransaction’ has not been declared
make[2]: *** [kmymoney/mymoney/CMakeFiles/mymoneyfiletest.dir/mymoneyfiletest.cpp.o] Error 1
make[1]: *** [kmymoney/mymoney/CMakeFiles/mymoneyfiletest.dir/all] Error 2
make: *** [all] Error 2

Was I working for some reason in another build directory when running this test successfully?

Only now I see that the t.setState()-call appears only twice in comments made by Thomas and in my function.</pre>
</div>
<br />



<p>- Marko</p>


<br />
<p>On January 6th, 2013, 8:25 p.m., Marko Käning wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KMymoney and Łukasz Maszczyński.</div>
<div>By Marko Käning.</div>


<p style="color: grey;"><i>Updated Jan. 6, 2013, 8:25 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch introduces new columns in the accounts tables on KMM's homepage (similar to [1]) which will list the number of not marked transactions for each specific account.

This information will give the user the chance to immediately spot accounts which aren't properly looked after.


---
[1] "homepage: extend accounts table with additional columns to reflect online-status" https://git.reviewboard.kde.org/r/107364/</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and runs fine.

TODO:
 - implement tests for MyMoneyFile::countNotReconciledTransactions(const QString& accId)</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kmymoney/dialogs/settings/ksettingshomedecl.ui <span style="color: grey">(4cb36cced4801f5d6ecf35ef84f375a629cd8792)</span></li>

 <li>kmymoney/kmymoney.kcfg <span style="color: grey">(a60ccad153385c961fa15c5b0964588c14e7ad89)</span></li>

 <li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(c43977ce7413eee2bc1e0a841fa548314c71e9df)</span></li>

 <li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(6640356d5e07152f8eb4aecff23d62ee8d853dbd)</span></li>

 <li>kmymoney/mymoney/mymoneyfiletest.h <span style="color: grey">(5551fa94b6b34022c8e91c0301847d5479e6b1f2)</span></li>

 <li>kmymoney/mymoney/mymoneyfiletest.cpp <span style="color: grey">(feb9d57ecd7156fc1eea189a905fa797aeae9183)</span></li>

 <li>kmymoney/views/khomeview.cpp <span style="color: grey">(c79337176b7265cabe15cad4972bc719e797af7c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108150/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/108150/s/985/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/06/KMM-not-reconciled_400x100.png" style="border: 1px black solid;" alt="accounts tables with the additional column for the number of not reconciled transactions" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>