[Kmymoney-devel] Review Request 112028: Drop unused #define's

[Łukasz Maszczyński]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112028/#review37597
-----------------------------------------------------------


Looks fine to me - neither PACKAGE_STRING, nor PACKAGE_VERSION is used anywhere in the project. 

Unless package maintainers (.deb/.rpm/...) do some kinky stuff with those defines, I think they should be removed.

- Łukasz Maszczyński


On Aug. 12, 2013, 11:13 a.m., Yury Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112028/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 11:13 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> These macros are never used.
> git pull kde:clones/kmymoney/kudryashov/kmymoney drop-unused-defs
> to apply this patch locally
> 
> 
> Diffs
> -----
> 
>   config-kmymoney-version.h.cmake 8fcb95c6668b81be3b6413b666461a8c74b12eeb 
> 
> Diff: http://git.reviewboard.kde.org/r/112028/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yury Kudryashov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20130812/6a864dc0/attachment.html>