<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112028/">http://git.reviewboard.kde.org/r/112028/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me - neither PACKAGE_STRING, nor PACKAGE_VERSION is used anywhere in the project.
Unless package maintainers (.deb/.rpm/...) do some kinky stuff with those defines, I think they should be removed.</pre>
<br />
<p>- Łukasz</p>
<br />
<p>On August 12th, 2013, 11:13 a.m. UTC, Yury Kudryashov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Yury Kudryashov.</div>
<p style="color: grey;"><i>Updated Aug. 12, 2013, 11:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These macros are never used.
git pull kde:clones/kmymoney/kudryashov/kmymoney drop-unused-defs
to apply this patch locally</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config-kmymoney-version.h.cmake <span style="color: grey">(8fcb95c6668b81be3b6413b666461a8c74b12eeb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112028/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>