[Kmymoney-devel] Review Request: When KWallet is opened synchronously do it in a safe way.

[Martin Preuss]

Hi,

the password stuff is inside the OFX plugin, because it is only used by
the OFX plugin. But we do have another potential use for such a
mechanism: German users might want to store their passwords for HBCI as
well.

At least there should be room to implement that later, i.e. I believe
this should be located in a more generic class, so that other modules
can use the wallet consistently...


Regards
Martin


Am 28.11.2012 21:19, schrieb Cristian Oneț:
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107507/
> 
> 
> Review request for KMymoney.
> By Cristian Oneț.
> 
> /Updated Nov. 28, 2012, 8:19 p.m./
> 
> 
>   Changes
> 
> The previous patch had some unnecessary includes.
> 
> 
>   Description
> 
> KWallet API is pretty cumbersome if we need to do this kind of hacking to make it's usage safe.
> I thought I'll put this one up for review to get your opinion about a fix like this.
> I would have preferred using a progress dialog as a permanent parent for the open operation but this was faster to write.
> 
> 
>   Testing
> 
> The main window can't be touched until the wallet dialog is dismissed one way or the other.
> 
> *Bugs: * 255764 <http://bugs.kde.org/show_bug.cgi?id=255764>
> 
> 
>   Diffs (updated)
> 
>   * kmymoney/kmymoney.cpp (fafceb0)
>   * kmymoney/plugins/ofximport/dialogs/konlinebankingstatus.cpp (faf7757)
>   * kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.h (5538a5d)
>   * kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.cpp (4fc0c0d)
>   * kmymoney/plugins/ofximport/ofximporterplugin.cpp (92dc76b)
> 
> View Diff <http://git.reviewboard.kde.org/r/107507/diff/>
> 
> 
> 
> _______________________________________________
> KMyMoney-devel mailing list
> KMyMoney-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel
> 


-- 
"Things are only impossible until they're not"

AqBanking - http://www.aqbanking.de/