[Kmymoney-devel] Review Request: homepage: extend accounts table with additional columns to reflect online-status

[Marko Käning]

> On Nov. 24, 2012, 11:51 a.m., Alvaro Soliverez wrote:
> > kmymoney/views/khomeview.cpp, line 1287
> > <http://git.reviewboard.kde.org/r/107364/diff/6/?file=96040#file96040line1287>
> >
> >     You could use colspan="2" where it belongs, instead of adding a dummy column.

Hmm, I'm not sure whether colspan could cause alignment problems in the resulting combined table columns then.

However, if you think it should (and not only "could") be reworked I'll have a look into it.


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107364/#review22471
-----------------------------------------------------------


On Nov. 24, 2012, 11:42 a.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107364/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2012, 11:42 a.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Description
> -------
> 
> Homepage: extend accounts tables with additional columns to reflect online-status
>  * green check-mark  -> for accounts with matching file and online balance
>  * red warning -> for accounts with unequal file and online balance
>  * a minus -> for accounts without a valid online balance  
> 
> The status column - being right now in between account name and balance - could also be moved in front of the account name or after the balance, depending on what usability dictates...
> 
> This feature is opt-in configurable from application preferences for users who have no need for this. (Thanks to David Houlden for his feedback!)
> 
> I've posted this to ReviewBoard to get feedback from users but also from core-devs whether the implementation of such a feature would make sense.
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/settings/ksettingshomedecl.ui df9b95c80bea637bfe8f644c1797e367cdfbba03 
>   kmymoney/kmymoney.kcfg 5b6658615c7d7e74b71aff4d4a2bf7cc4a322823 
>   kmymoney/views/khomeview.cpp 498e4a5d568500ab145f11e654f2e482dba652b4 
> 
> Diff: http://git.reviewboard.kde.org/r/107364/diff/
> 
> 
> Testing
> -------
> 
> built and ran w/o problems
> 
> 
> Screenshots
> -----------
> 
> online-status columns in "Assets and Liabilities Summary", "Preferred Accounts" and "Payment Accounts" tables
>   http://git.reviewboard.kde.org/r/107364/s/851/
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20121124/e4e4d28a/attachment.html>