<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107364/">http://git.reviewboard.kde.org/r/107364/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 24th, 2012, 11:51 a.m., <b>Alvaro Soliverez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107364/diff/6/?file=96040#file96040line1287" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/views/khomeview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KHomeView::showAssetsLiabilities(void)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1287</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">tmp_os</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could use colspan="2" where it belongs, instead of adding a dummy column.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, I'm not sure whether colspan could cause alignment problems in the resulting combined table columns then.
However, if you think it should (and not only "could") be reworked I'll have a look into it.</pre>
<br />
<p>- Marko</p>
<br />
<p>On November 24th, 2012, 11:42 a.m., Marko Käning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Nov. 24, 2012, 11:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Homepage: extend accounts tables with additional columns to reflect online-status
* green check-mark -> for accounts with matching file and online balance
* red warning -> for accounts with unequal file and online balance
* a minus -> for accounts without a valid online balance
The status column - being right now in between account name and balance - could also be moved in front of the account name or after the balance, depending on what usability dictates...
This feature is opt-in configurable from application preferences for users who have no need for this. (Thanks to David Houlden for his feedback!)
I've posted this to ReviewBoard to get feedback from users but also from core-devs whether the implementation of such a feature would make sense.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">built and ran w/o problems</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/settings/ksettingshomedecl.ui <span style="color: grey">(df9b95c80bea637bfe8f644c1797e367cdfbba03)</span></li>
<li>kmymoney/kmymoney.kcfg <span style="color: grey">(5b6658615c7d7e74b71aff4d4a2bf7cc4a322823)</span></li>
<li>kmymoney/views/khomeview.cpp <span style="color: grey">(498e4a5d568500ab145f11e654f2e482dba652b4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107364/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107364/s/851/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/24/KMM-homepage-online-status_400x100.png" style="border: 1px black solid;" alt="online-status columns in "Assets and Liabilities Summary", "Preferred Accounts" and "Payment Accounts" tables" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>