[Kmymoney-devel] Review Request: Prices: search reciprocal value before searching previous dates

[Jack Ostroff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104786/#review13187
-----------------------------------------------------------


I don't have much experience with multiple currencies, but Thomas' comments made me think.  I know when changing money at a bank, the two rates are not reciprocal, because the bank makes some money on each exchange.  Is this also true for the exchange rates KMM retrieves on-line?  If the rates are reciprocal, then the closest date is most accurate (can the date be later than the transaction instead of earlier?)  However, if the rates are NOT reciprocal, than how preferable is a correct rate to a reciprocal rate on a closer date?

Jack


- Jack Ostroff


On April 30, 2012, 11:11 p.m., Alvaro Soliverez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104786/
> -----------------------------------------------------------
> 
> (Updated April 30, 2012, 11:11 p.m.)
> 
> 
> Review request for KMymoney and Thomas Baumgart.
> 
> 
> Description
> -------
> 
> There may be cases where only the reciprocal value for a given date is present, but if there is a price for a previous date, the latter will be used instead.
> The fix here intends to use the most accurate value, which is the one in the exact date, even if it's the reciprocal one.
> 
> There might be performance issues. Perhaps a price cache should be considered in the future.
> 
> 
> This addresses bug 297437.
>     http://bugs.kde.org/show_bug.cgi?id=297437
> 
> 
> Diffs
> -----
> 
>   kmymoney/mymoney/mymoneyfile.cpp eef7126 
> 
> Diff: http://git.reviewboard.kde.org/r/104786/diff/
> 
> 
> Testing
> -------
> 
> Ran reports where this case is present, and unit tests.
> There was no noticeable performance problem, but the set of prices was normal.
> 
> 
> Thanks,
> 
> Alvaro Soliverez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kmymoney-devel/attachments/20120501/6c19225d/attachment.html>